Skip to content

[2.8] Revert inverted index iterator changes#5605

Merged
GuyAv46 merged 1 commit into2.8from
backport-5596-to-2.8
Feb 5, 2025
Merged

[2.8] Revert inverted index iterator changes#5605
GuyAv46 merged 1 commit into2.8from
backport-5596-to-2.8

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Feb 5, 2025

Description

Backport of #5596 to 2.8.

* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change

(cherry picked from commit 8d3282d)
@GuyAv46 GuyAv46 requested a review from raz-mon February 5, 2025 14:43
@GuyAv46 GuyAv46 enabled auto-merge February 5, 2025 14:44
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (e8f3b8a) to head (c0e1d18).
Report is 1 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/inverted_index.c 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #5605      +/-   ##
==========================================
- Coverage   85.85%   85.85%   -0.01%     
==========================================
  Files         200      200              
  Lines       34315    34320       +5     
==========================================
+ Hits        29462    29466       +4     
- Misses       4853     4854       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into 2.8 with commit 795b6f0 Feb 5, 2025
10 checks passed
@GuyAv46 GuyAv46 deleted the backport-5596-to-2.8 branch February 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants