Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #5596 +/- ##
==========================================
- Coverage 87.49% 87.45% -0.05%
==========================================
Files 196 196
Lines 34155 34160 +5
==========================================
- Hits 29884 29873 -11
- Misses 4271 4287 +16 ☔ View full report in Codecov by Sentry. |
raz-mon
reviewed
Feb 4, 2025
raz-mon
reviewed
Feb 4, 2025
DvirDukhan
reviewed
Feb 5, 2025
raz-mon
reviewed
Feb 5, 2025
raz-mon
approved these changes
Feb 5, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5596-to-2.8 origin/2.8
cd .worktree/backport-5596-to-2.8
git switch --create backport-5596-to-2.8
git cherry-pick -x 8d3282df7633e1d1928cee4887d47e05fef9ff9c |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5596-to-2.6 origin/2.6
cd .worktree/backport-5596-to-2.6
git switch --create backport-5596-to-2.6
git cherry-pick -x 8d3282df7633e1d1928cee4887d47e05fef9ff9c |
GuyAv46
added a commit
that referenced
this pull request
Feb 5, 2025
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
GuyAv46
added a commit
that referenced
this pull request
Feb 5, 2025
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
This was referenced Feb 5, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Revert inverted index iterator changes (#5596) * Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d) * fix test for 2.6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Revert inverted index iterator changes (#5596) * Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Reverting minor improvements introduced in #5350, #5364, and a followup introduced in #5528
Complimentary to #5591 for master and 8.0.
Which additional issues this PR fixes
Mark if applicable