Fix SkipTo edge case - [MOD-8561 MOD-8673]#5591
Merged
Conversation
kei-nan
reviewed
Feb 2, 2025
|
|
||
| idx->numDocs -= info->ndocsCollected; | ||
| idx->gcMarker++; | ||
| idx->lastId = idx->blocks[idx->size - 1].lastId; // Update lastId |
Collaborator
There was a problem hiding this comment.
isn't it possible idx->size is zero?
Collaborator
Author
There was a problem hiding this comment.
Nope. If we delete all the blocks, we add an empty one.
Yet, I can add a validation here
Collaborator
There was a problem hiding this comment.
I think let's have an assertion, max
kei-nan
reviewed
Feb 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5591 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 196 196
Lines 35285 35288 +3
=======================================
+ Hits 30795 30798 +3
Misses 4490 4490 ☔ View full report in Codecov by Sentry. |
raz-mon
previously approved these changes
Feb 2, 2025
|
|
||
| idx->numDocs -= info->ndocsCollected; | ||
| idx->gcMarker++; | ||
| idx->lastId = idx->blocks[idx->size - 1].lastId; // Update lastId |
Collaborator
There was a problem hiding this comment.
I think let's have an assertion, max
GuyAv46
changed the title
raz-mon
approved these changes
Feb 3, 2025
raz-mon
changed the title
kei-nan
approved these changes
Feb 3, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5591-to-2.8 origin/2.8
cd .worktree/backport-5591-to-2.8
git switch --create backport-5591-to-2.8
git cherry-pick -x c29e9bccd5136fec493245810e316fb9b8da4cdf |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5591-to-2.6 origin/2.6
cd .worktree/backport-5591-to-2.6
git switch --create backport-5591-to-2.6
git cherry-pick -x c29e9bccd5136fec493245810e316fb9b8da4cdf |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5591-to-2.10 origin/2.10
cd .worktree/backport-5591-to-2.10
git switch --create backport-5591-to-2.10
git cherry-pick -x c29e9bccd5136fec493245810e316fb9b8da4cdf |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* add a failing test * add an assertion * fix the bug * add another assertion * add another scenario * add an assertion to the gc * rename test * simplified test * simplified simplification (cherry picked from commit c29e9bc)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Fix SkipTo edge case - [MOD-8561 MOD-8673] (#5591) * add a failing test * add an assertion * fix the bug * add another assertion * add another scenario * add an assertion to the gc * rename test * simplified test * simplified simplification (cherry picked from commit c29e9bc) Co-authored-by: GuyAv46 <[email protected]>
GuyAv46
added a commit
that referenced
this pull request
Feb 4, 2025
* add a failing test * add an assertion * fix the bug * add another assertion * add another scenario * add an assertion to the gc * rename test * simplified test * simplified simplification (cherry picked from commit c29e9bc)
GuyAv46
added a commit
that referenced
this pull request
Feb 4, 2025
* add a failing test * add an assertion * fix the bug * add another assertion * add another scenario * add an assertion to the gc * rename test * simplified test * simplified simplification (cherry picked from commit c29e9bc)
GuyAv46
added a commit
that referenced
this pull request
Feb 4, 2025
* add a failing test * add an assertion * fix the bug * add another assertion * add another scenario * add an assertion to the gc * rename test * simplified test * simplified simplification (cherry picked from commit c29e9bc)
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix a bug in the GC, which should update the last ID of an inverted index when cleaning it, in case it was modified.
This last ID in the index is used in the inverted-index reader iterator to test if we can expect more results from this iterator quickly.
An edge case where the last id(s) were deleted and this value was not up-to-date could cause the index reader iterator to assume it has a block to skip to, while that's not the case, causing unsafe access to the end of the block array.
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable