Skip to content

[8.0] Fix Empty Numeric Value - [MOD-7244]#5580

Merged
dor-forer merged 2 commits into8.0from
backport-5566-to-8.0
Feb 4, 2025
Merged

[8.0] Fix Empty Numeric Value - [MOD-7244]#5580
dor-forer merged 2 commits into8.0from
backport-5566-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

Description

Backport of #5566 to 8.0.

* Adding numeric check

* changes

* change to each one

* MOD-6786 Fix search on larger then 128 terms (#5524)

* Move length slicing to NOMODIFY if

* add py test

* fix slicing

* fix test

* fix text skip cluster

* Adding comments

* Update test_issues - skip cluster

* MOD-8561: Fix Inverted Index SeekTo Edge Case (#5528)

* * initial commit

* * simplify the fix

* * revert to old code to solve edge case

* Load config params for Redis 8.0-m03 (#5538)

* Load config params for Redis v7.9.226

* Add step to get latest unreleased redis tag

* Remove commented-out step `Get Latest Release Tag with Prefix`

* Revert: task-get-latest-tag.yml

* MOD-8601: Fix error message for LOAD (#5531)

* Enhance error message for LOAD

* Fix error message

* Address review

* Fix flakiness in a test (#5541)

* fix flakiness

* revert whitespace change

* Fix Max Frequency Misscalculation - [MOD-8158] (#5553)

* fix unrelated test

* add a failing test

* fix issue

* revert whitespace change from test_vecsim.py

* revert whitespace change in test_issues.py

* Fix APPLY/FILTER parser - [MOD-7804] (#5520)

* fix order of operations

* minor improvements to the lexer

* improve functions parsing

* optimize "NOT" logic and perform arithmetic operations immediately

* fix flow tests

* fix grammar optimization

* changed function API

* added a test

* minor fix

* fix precedence

* minor improvement

* reorder rule and fix leak

* another fix

* added test

* more tests for a better coverage

* improved test

* fix assertion

* review fixes

* address code review

* added comments

* remove unncessary

* Added tests for legacy filter empty

* Adding numeric check

* changes

* change to each one

* remove unncessary

* Added tests for legacy filter empty

* * Change the order of params
* Add support in GEOFILTER

* Forgot one file

* * Changed to AC_GetString with no advance
* Added comment
* change the string check

* PR changes

* Changes

* push the test

* change style

---------

Co-authored-by: lerman25 <[email protected]>
Co-authored-by: kei-nan <[email protected]>
Co-authored-by: nafraf <[email protected]>
Co-authored-by: Raz Monsonego <[email protected]>
Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit e4d8fa0)
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (b905973) to head (a0cdd08).
Report is 3 commits behind head on 8.0.

Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #5580   +/-   ##
=======================================
  Coverage   87.23%   87.24%           
=======================================
  Files         196      196           
  Lines       35225    35250   +25     
=======================================
+ Hits        30730    30753   +23     
- Misses       4495     4497    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dor-forer
dor-forer previously approved these changes Feb 2, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2025
@dor-forer dor-forer requested a review from GuyAv46 February 2, 2025 11:42
@GuyAv46 GuyAv46 added this pull request to the merge queue Feb 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@dor-forer dor-forer added this pull request to the merge queue Feb 4, 2025
Merged via the queue into 8.0 with commit c716c29 Feb 4, 2025
10 checks passed
@dor-forer dor-forer deleted the backport-5566-to-8.0 branch February 4, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants