Skip to content

[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case#5536

Merged
kei-nan merged 2 commits into2.10from
backport-5528-to-2.10
Jan 23, 2025
Merged

[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case#5536
kei-nan merged 2 commits into2.10from
backport-5528-to-2.10

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Jan 22, 2025

Description

Backport of #5528 to 2.10.

@kei-nan @github-actions
MOD-8561: Fix Inverted Index SeekTo Edge Case (#5528)
29a3931 
* * initial commit

* * simplify the fix

* * revert to old code to solve edge case

(cherry picked from commit 50e3f01)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Jan 22, 2025
Merged
2 tasks
kei-nan
kei-nan previously approved these changes Jan 23, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.48%. Comparing base (8b75285) to head (bcadbbb).
Report is 1 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/inverted_index.c 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.10    #5536      +/-   ##
==========================================
- Coverage   87.49%   87.48%   -0.01%     
==========================================
  Files         196      196              
  Lines       34145    34150       +5     
==========================================
+ Hits        29875    29876       +1     
- Misses       4270     4274       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kei-nan kei-nan enabled auto-merge January 23, 2025 08:36
@kei-nan kei-nan disabled auto-merge January 23, 2025 08:37
@kei-nan kei-nan enabled auto-merge January 23, 2025 08:37
@kei-nan kei-nan requested a review from GuyAv46 January 23, 2025 08:37
@kei-nan kei-nan added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@kei-nan kei-nan added this pull request to the merge queue Jan 23, 2025
Merged via the queue into 2.10 with commit f9923b7 Jan 23, 2025
10 checks passed
@kei-nan kei-nan deleted the backport-5528-to-2.10 branch January 23, 2025 10:30
raz-mon added a commit that referenced this pull request Jan 30, 2025
@raz-mon
Revert "[2.10] Fix Max Frequency Misscalculation - [MOD-8158] (#5557)"
337a625 
This reverts commit a97e925.

Revert "[2.10] MOD-8601: Fix error message for LOAD (#5531) (#5550)"

This reverts commit 5748233.

Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

Revert "[2.10] Fix legacy geofilter leak - [MOD-8568] (#5516)"

This reverts commit 8b75285.

Revert "[2.10] MOD-7872: Add Types To Hide User Input (#5485)"

This reverts commit d6acfed.

Revert "[2.10] MOD-7864: Obfuscation API (#5487)"

This reverts commit 259d417.

Revert "MOD-7570 Backport 5422 to 2.10 (#5472)"

This reverts commit e699dbc.

Revert "[2.10] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5446)"

This reverts commit a90cfc3.

Revert "[2.10] MOD-8058: Avoid error with _NUM_SSTRING (#5424)"

This reverts commit 885cffb.

Revert "[2.10] MOD-7634: Fix NOSTEM (#5392)"

This reverts commit 4df508d.

Revert "[2.10] Fixes for inverted indexes encoding - [MOD-8248] (#5388)"

This reverts commit bc003c1.

Revert "[2.10] Improve "Raw doc id" encoding - [MOD-8255] (#5372)"

This reverts commit 9789e30.

Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

Revert "[2.10] Improve counting active writes - [MOD-8151] (#5362)"

This reverts commit a3d447d.

Revert "[2.10] [MOD-8039] Reorganize stats files (#5356)"

This reverts commit a1b8b29.

Revert "[2.10] Improve text indexing performance - [MOD-8249] (#5352)"

This reverts commit c5c9245.

Revert "[2.10] [MOD-8115] Free spec resources in the main thread (#5327)"

This reverts commit 42bb520.

Revert "[2.10] Sorting Vector - [MOD-6783] (#5314)"

This reverts commit 166a00e.

Revert "[2.10] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5300)"

This reverts commit 5c4ed74.

Revert "[2.10] Remove assertion in optimizer (#5292)"

This reverts commit ba55efb.

Revert "[2.10] Fix missing expansions in text queries - [MOD-8142] (#5284)"
This reverts commit 10f32d3.

Revert "[2.10] Fix Tag OnReopen Callback - [MOD-8011] (#5282)"

This reverts commit 2c029ee.

Revert "[2.10] Fix MRIterator ownership mechanism - [MOD-8108] (#5266)"

This reverts commit 457536e.

Revert "[2.10] [MOD-8125] Create inverted index in write operations only (#5257)"

This reverts commit 555557c.

Revert "[2.10] [MOD-8152] rename and move new metrics (#5255)"

This reverts commit a1f460e.

Revert "[2.10] MOD-8129: Fix indexed_percent info stat (#5247)"

This reverts commit d55afb5.

Revert "[2.10] MOD-8097, MOD-8114 Fix memory counting (#5204) (#5241)"

This reverts commit 52e58af.

Revert "[MOD-7949] Avoid lazy expire upon scan keys in background [2.10] (#5294)"

This reverts commit 6dfb503.

Revert "[2.10] Cleanup for the trimming tree logic (#5226)"

This reverts commit 7dfe6a2.

Revert "[2.10] Add global marked deleted to stats [MOD-6053] (#5208)"

This reverts commit f396732.

Revert "Fix and add skips in pytest (#5210)"

This reverts commit a8b505c.

Revert "[2.10] [MOD-8035] Add field index error for JSON field indexing failures (#5202)"

This reverts commit ed1919e.

Revert "[2.10] Improve usage of RedisModuleCtx (#5181)"

This reverts commit 8e686c7.

Revert "[2.10] Add Active Indices Metrics - [MOD-7952] (#5179)"

This reverts commit b72fc38.

Revert "[2.10] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5166)"

This reverts commit 92e1dd8.

Revert "[2.10] Send `SCORER` to the shards with `FT.AGGREGATE` on cluster mode - [MOD-8060] (#5163)"

This reverts commit 4982ea2.

Revert "[2.10] [MOD-8034] expose indexing failures to INFO modules (#5158)"

This reverts commit d03f8de.

Revert "[2.10] Add a counter of total query execution time - [MOD-7961] (#5153)"

This reverts commit d45365d.

Revert "[2.10] Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5146)"

This reverts commit 094318f.

Revert "[2.10] Remove an unnecessary assertion - [MOD-8008] (#5142)"

This reverts commit 3156f08.

Revert "[2.10] Skip test_multithread:test_async_updates_sanity with sanitizer  (#5125)"

This reverts commit 5339033.

Revert "Count Queries - [MOD-6492] (#5072)"

This reverts commit 1006065.

Revert "[2.10] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5109)"

This reverts commit 9621fdc.

Revert "[2.10] Fix flaky test (#5086)"

This reverts commit 5aff118.

Revert "[2.10] Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5081)"

This reverts commit 2b85289.

Revert "[2.10] MOD-7745: Add Benchmarks For Document And Field Expiration (#5063)"

This reverts commit f99b0cf.

Revert "[2.10] MOD-7863: Add HPEXPIRETIME Mock Support (#5028)"

This reverts commit 79dfd0f.
@raz-mon raz-mon mentioned this pull request Jan 30, 2025
Closed
raz-mon added a commit that referenced this pull request Jan 31, 2025
@raz-mon
Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"
a8d0a56 
This reverts commit f9923b7.

Revert "[2.10] Fixes for inverted indexes encoding - [MOD-8248] (#5388)"

This reverts commit bc003c1.

Revert "[2.10] Improve "Raw doc id" encoding - [MOD-8255] (#5372)"

This reverts commit 9789e30.

Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

Revert "[2.10] Fix Tag OnReopen Callback - [MOD-8011] (#5282)"

This reverts commit 2c029ee.

Revert "[2.10] Cleanup for the trimming tree logic (#5226)"

This reverts commit 7dfe6a2.
GuyAv46 added a commit that referenced this pull request Feb 4, 2025
@GuyAv46
Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"
767fd63 
This reverts commit f9923b7.
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@GuyAv46
Revert inverted index iterator changes (#5596)
8d3282d 
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change
GuyAv46 added a commit that referenced this pull request Feb 5, 2025
@GuyAv46
Revert inverted index iterator changes (#5596)
c0e1d18 
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change

(cherry picked from commit 8d3282d)
GuyAv46 added a commit that referenced this pull request Feb 5, 2025
@GuyAv46
Revert inverted index iterator changes (#5596)
c75b677 
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change

(cherry picked from commit 8d3282d)
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@GuyAv46
[2.6] Revert inverted index iterator changes (#5606)
59c72ec 
* Revert inverted index iterator changes (#5596)

* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change

(cherry picked from commit 8d3282d)

* fix test for 2.6
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
@GuyAv46
[2.8] Revert inverted index iterator changes (#5605)
795b6f0 
Revert inverted index iterator changes (#5596)

* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)"

This reverts commit f9923b7.

* Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)"

This reverts commit 56b16ea.

* partial revert of #5364

* address CR, added tests

* test improvement

* Improve test and fix bug (remove revert)

* remove temporary change

(cherry picked from commit 8d3282d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kei-nan kei-nan kei-nan approved these changes

@GuyAv46 GuyAv46 GuyAv46 approved these changes

Assignees

@kei-nan kei-nan

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kei-nan @GuyAv46