Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5531 +/- ##
==========================================
- Coverage 87.21% 87.20% -0.02%
==========================================
Files 196 196
Lines 35226 35232 +6
==========================================
+ Hits 30723 30724 +1
- Misses 4503 4508 +5 ☔ View full report in Codecov by Sentry. |
Itzikvaknin
previously approved these changes
Jan 21, 2025
kei-nan
reviewed
Jan 21, 2025
oshadmi
reviewed
Jan 21, 2025
oshadmi
approved these changes
Jan 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5531-to-2.8 origin/2.8
cd .worktree/backport-5531-to-2.8
git switch --create backport-5531-to-2.8
git cherry-pick -x 93479154ed1c76ed35eeef3f4d2a8c6ebe66fe5d |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5531-to-2.6 origin/2.6
cd .worktree/backport-5531-to-2.6
git switch --create backport-5531-to-2.6
git cherry-pick -x 93479154ed1c76ed35eeef3f4d2a8c6ebe66fe5d |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5531-to-2.10 origin/2.10
cd .worktree/backport-5531-to-2.10
git switch --create backport-5531-to-2.10
git cherry-pick -x 93479154ed1c76ed35eeef3f4d2a8c6ebe66fe5d |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5531-to-8.0 origin/8.0
cd .worktree/backport-5531-to-8.0
git switch --create backport-5531-to-8.0
git cherry-pick -x 93479154ed1c76ed35eeef3f4d2a8c6ebe66fe5d |
raz-mon
added a commit
that referenced
this pull request
Jan 23, 2025
* Enhance error message for LOAD * Fix error message * Address review
raz-mon
added a commit
that referenced
this pull request
Jan 23, 2025
* Enhance error message for LOAD * Fix error message * Address review
raz-mon
added a commit
that referenced
this pull request
Jan 23, 2025
* Enhance error message for LOAD * Fix error message * Address review
raz-mon
added a commit
that referenced
this pull request
Jan 23, 2025
* Enhance error message for LOAD * Fix error message * Address review
dor-forer
pushed a commit
that referenced
this pull request
Jan 26, 2025
* Enhance error message for LOAD * Fix error message * Address review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Adding numeric check * changes * change to each one * MOD-6786 Fix search on larger then 128 terms (#5524) * Move length slicing to NOMODIFY if * add py test * fix slicing * fix test * fix text skip cluster * Adding comments * Update test_issues - skip cluster * MOD-8561: Fix Inverted Index SeekTo Edge Case (#5528) * * initial commit * * simplify the fix * * revert to old code to solve edge case * Load config params for Redis 8.0-m03 (#5538) * Load config params for Redis v7.9.226 * Add step to get latest unreleased redis tag * Remove commented-out step `Get Latest Release Tag with Prefix` * Revert: task-get-latest-tag.yml * MOD-8601: Fix error message for LOAD (#5531) * Enhance error message for LOAD * Fix error message * Address review * Fix flakiness in a test (#5541) * fix flakiness * revert whitespace change * Fix Max Frequency Misscalculation - [MOD-8158] (#5553) * fix unrelated test * add a failing test * fix issue * revert whitespace change from test_vecsim.py * revert whitespace change in test_issues.py * Fix APPLY/FILTER parser - [MOD-7804] (#5520) * fix order of operations * minor improvements to the lexer * improve functions parsing * optimize "NOT" logic and perform arithmetic operations immediately * fix flow tests * fix grammar optimization * changed function API * added a test * minor fix * fix precedence * minor improvement * reorder rule and fix leak * another fix * added test * more tests for a better coverage * improved test * fix assertion * review fixes * address code review * added comments * remove unncessary * Added tests for legacy filter empty * Adding numeric check * changes * change to each one * remove unncessary * Added tests for legacy filter empty * * Change the order of params * Add support in GEOFILTER * Forgot one file * * Changed to AC_GetString with no advance * Added comment * change the string check * PR changes * Changes * push the test * change style --------- Co-authored-by: lerman25 <[email protected]> Co-authored-by: kei-nan <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Adding numeric check * changes * change to each one * MOD-6786 Fix search on larger then 128 terms (#5524) * Move length slicing to NOMODIFY if * add py test * fix slicing * fix test * fix text skip cluster * Adding comments * Update test_issues - skip cluster * MOD-8561: Fix Inverted Index SeekTo Edge Case (#5528) * * initial commit * * simplify the fix * * revert to old code to solve edge case * Load config params for Redis 8.0-m03 (#5538) * Load config params for Redis v7.9.226 * Add step to get latest unreleased redis tag * Remove commented-out step `Get Latest Release Tag with Prefix` * Revert: task-get-latest-tag.yml * MOD-8601: Fix error message for LOAD (#5531) * Enhance error message for LOAD * Fix error message * Address review * Fix flakiness in a test (#5541) * fix flakiness * revert whitespace change * Fix Max Frequency Misscalculation - [MOD-8158] (#5553) * fix unrelated test * add a failing test * fix issue * revert whitespace change from test_vecsim.py * revert whitespace change in test_issues.py * Fix APPLY/FILTER parser - [MOD-7804] (#5520) * fix order of operations * minor improvements to the lexer * improve functions parsing * optimize "NOT" logic and perform arithmetic operations immediately * fix flow tests * fix grammar optimization * changed function API * added a test * minor fix * fix precedence * minor improvement * reorder rule and fix leak * another fix * added test * more tests for a better coverage * improved test * fix assertion * review fixes * address code review * added comments * remove unncessary * Added tests for legacy filter empty * Adding numeric check * changes * change to each one * remove unncessary * Added tests for legacy filter empty * * Change the order of params * Add support in GEOFILTER * Forgot one file * * Changed to AC_GetString with no advance * Added comment * change the string check * PR changes * Changes * push the test * change style --------- Co-authored-by: lerman25 <[email protected]> Co-authored-by: kei-nan <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit e4d8fa0)
kei-nan
added a commit
that referenced
this pull request
Jan 30, 2025
kei-nan
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit ef25dca. Revert "[2.8] Fix Max Frequency Misscalculation - [MOD-8158] (#5560)" This reverts commit a6864e3. Revert "[2.8] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5542)" This reverts commit bb873af. Revert "[2.8] Fix legacy geofilter leak - [MOD-8568] (#5518)" This reverts commit 979f3d2. Revert "Backport 4243 to 2.8 (#5508)" This reverts commit 9af7959. Revert "MOD-7570 Backport 5422 to 2.8 (#5470)" This reverts commit 540b5f3. Revert "[2.8] MOD-7872: Add Types To Hide User Input (#5489)" This reverts commit b2bf242. Revert "[2.8] MOD-7864: Obfuscation API (#5488)" This reverts commit 4866bf1. Revert "[2.8] MOD-7634: Fix NOSTEM (#5475)" This reverts commit a015a55. Revert "[2.8] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5444)" This reverts commit baadb4d. Revert "[2.8] MOD-8058: Avoid error with _NUM_SSTRING (#5187) (#5427)" This reverts commit 5b49276. Revert "Backport metrics info 2.8 [MOD-8388] (#5407)" This reverts commit f428033. Revert " [2.8] Fixes for inverted indexes encoding - [MOD-8248] (#5389)" This reverts commit 0c7227e. Revert "[2.8] MOD-8221: backport info fields (for metrics) to 2.8 (#5358)" This reverts commit b7eaa56. Revert "[2.8] Improve "Raw doc id" encoding - [MOD-8255] (#5371)" This reverts commit 152043b. Revert "[2.8] Improve SkipToBlock logic - [MOD-8255] (#5369)" This reverts commit c1a2c8f. Revert "[2.8][MOD-8115] Free spec resources in the main thread (#5324) (#5330)" This reverts commit 5f3ce64. Revert "[2.8] Fix Sorting Vector - [MOD-6783] (#5316)" This reverts commit 04f7778. Revert "[2.8] Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5305)" This reverts commit 4fc1b27. Revert "[MOD-7949] Avoid lazy expire upon scan keys in background [2.8] (#5303)" This reverts commit 16e4ff4. Revert "[2.8] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5299)" This reverts commit 09f5b62. Revert "[2.8] Remove assertion in optimizer (#5296)" This reverts commit 45db16a. Revert "[2.8] MOD-8188: Fix OnReopen Comments (#5288)" This reverts commit 001746f. Revert "[2.8] Fix missing expansions in text queries - [MOD-8142] (#5287)" This reverts commit ed13507. Revert "[2.8] Fix Tag OnReopen Callback - [MOD-8011] (#5280)" This reverts commit 40b8012. Revert "[2.8] Fix MRIterator ownership mechanism - [MOD-8108] (#5269)" This reverts commit 90a5685. Revert "[2.8] [MOD-8125] Create inverted index in write operations only (#5260)" This reverts commit ebb9484. Revert "[2.8] MOD-8129: Fix indexed_percent info stat (#5249)" This reverts commit fb9781a. Revert "[2.8] MOD-8097, MOD-8114 Fix memory counting (#5242)" This reverts commit a21a909. Revert "[2.8] Cleanup for the trimming tree logic (#5225)" This reverts commit 1b9126b. Revert "[2.8] [MOD-8035] Add field index error for JSON field indexing failures (#5205)" This reverts commit 3a13ddb. Revert "[2.8] Fix Numeric Tree Balance - [MOD-8081, MOD-8082] (#5200)" This reverts commit a2948c4. Revert "[2.8] Performance improvement in indexBulkFields - [MOD-8093] (#5192)" This reverts commit 2b0e0a0. Revert "[2.8] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5167)" This reverts commit f860505. Revert "[2.8] Skip test_multithread:test_async_updates_sanity with sanitizer (#5124)" This reverts commit 938369a. Revert "[2.8] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5108)" This reverts commit ba614ca. Revert "[2.8] Fix flaky test (#5084)" This reverts commit f579156. Revert "[2.8] Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5080)" This reverts commit 1a0eabc. Revert "[2.8] Handle VecSim in-place deletion after async [MOD-7643, MOD-7732] (#5048)" This reverts commit fcc19e9.
raz-mon
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit a97e925. Revert "[2.10] MOD-8601: Fix error message for LOAD (#5531) (#5550)" This reverts commit 5748233. Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. Revert "[2.10] Fix legacy geofilter leak - [MOD-8568] (#5516)" This reverts commit 8b75285. Revert "[2.10] MOD-7872: Add Types To Hide User Input (#5485)" This reverts commit d6acfed. Revert "[2.10] MOD-7864: Obfuscation API (#5487)" This reverts commit 259d417. Revert "MOD-7570 Backport 5422 to 2.10 (#5472)" This reverts commit e699dbc. Revert "[2.10] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5446)" This reverts commit a90cfc3. Revert "[2.10] MOD-8058: Avoid error with _NUM_SSTRING (#5424)" This reverts commit 885cffb. Revert "[2.10] MOD-7634: Fix NOSTEM (#5392)" This reverts commit 4df508d. Revert "[2.10] Fixes for inverted indexes encoding - [MOD-8248] (#5388)" This reverts commit bc003c1. Revert "[2.10] Improve "Raw doc id" encoding - [MOD-8255] (#5372)" This reverts commit 9789e30. Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. Revert "[2.10] Improve counting active writes - [MOD-8151] (#5362)" This reverts commit a3d447d. Revert "[2.10] [MOD-8039] Reorganize stats files (#5356)" This reverts commit a1b8b29. Revert "[2.10] Improve text indexing performance - [MOD-8249] (#5352)" This reverts commit c5c9245. Revert "[2.10] [MOD-8115] Free spec resources in the main thread (#5327)" This reverts commit 42bb520. Revert "[2.10] Sorting Vector - [MOD-6783] (#5314)" This reverts commit 166a00e. Revert "[2.10] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5300)" This reverts commit 5c4ed74. Revert "[2.10] Remove assertion in optimizer (#5292)" This reverts commit ba55efb. Revert "[2.10] Fix missing expansions in text queries - [MOD-8142] (#5284)" This reverts commit 10f32d3. Revert "[2.10] Fix Tag OnReopen Callback - [MOD-8011] (#5282)" This reverts commit 2c029ee. Revert "[2.10] Fix MRIterator ownership mechanism - [MOD-8108] (#5266)" This reverts commit 457536e. Revert "[2.10] [MOD-8125] Create inverted index in write operations only (#5257)" This reverts commit 555557c. Revert "[2.10] [MOD-8152] rename and move new metrics (#5255)" This reverts commit a1f460e. Revert "[2.10] MOD-8129: Fix indexed_percent info stat (#5247)" This reverts commit d55afb5. Revert "[2.10] MOD-8097, MOD-8114 Fix memory counting (#5204) (#5241)" This reverts commit 52e58af. Revert "[MOD-7949] Avoid lazy expire upon scan keys in background [2.10] (#5294)" This reverts commit 6dfb503. Revert "[2.10] Cleanup for the trimming tree logic (#5226)" This reverts commit 7dfe6a2. Revert "[2.10] Add global marked deleted to stats [MOD-6053] (#5208)" This reverts commit f396732. Revert "Fix and add skips in pytest (#5210)" This reverts commit a8b505c. Revert "[2.10] [MOD-8035] Add field index error for JSON field indexing failures (#5202)" This reverts commit ed1919e. Revert "[2.10] Improve usage of RedisModuleCtx (#5181)" This reverts commit 8e686c7. Revert "[2.10] Add Active Indices Metrics - [MOD-7952] (#5179)" This reverts commit b72fc38. Revert "[2.10] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5166)" This reverts commit 92e1dd8. Revert "[2.10] Send `SCORER` to the shards with `FT.AGGREGATE` on cluster mode - [MOD-8060] (#5163)" This reverts commit 4982ea2. Revert "[2.10] [MOD-8034] expose indexing failures to INFO modules (#5158)" This reverts commit d03f8de. Revert "[2.10] Add a counter of total query execution time - [MOD-7961] (#5153)" This reverts commit d45365d. Revert "[2.10] Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5146)" This reverts commit 094318f. Revert "[2.10] Remove an unnecessary assertion - [MOD-8008] (#5142)" This reverts commit 3156f08. Revert "[2.10] Skip test_multithread:test_async_updates_sanity with sanitizer (#5125)" This reverts commit 5339033. Revert "Count Queries - [MOD-6492] (#5072)" This reverts commit 1006065. Revert "[2.10] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5109)" This reverts commit 9621fdc. Revert "[2.10] Fix flaky test (#5086)" This reverts commit 5aff118. Revert "[2.10] Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5081)" This reverts commit 2b85289. Revert "[2.10] MOD-7745: Add Benchmarks For Document And Field Expiration (#5063)" This reverts commit f99b0cf. Revert "[2.10] MOD-7863: Add HPEXPIRETIME Mock Support (#5028)" This reverts commit 79dfd0f.
raz-mon
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit 2ea41bf. Revert "[2.6] Fix Max Frequency Misscalculation - [MOD-8158] (#5559)" This reverts commit 7e0288d. Revert "[2.6] Fix flakiness in a test - [MOD-8611] (#5546)" This reverts commit 1a43260. Revert "[2.6] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5543)" This reverts commit 1c2be01. Revert "Backport 4243 to 2.6 (#5509)" This reverts commit 5d90c3b. Revert "[2.6] Fix legacy geofilter leak - [MOD-8568] (#5519)" This reverts commit 221f139. Revert "MOD-7570 Backport 5422 to 2.6 (#5473)" This reverts commit a0f9d4b. Revert "[2.6] MOD-7864: Obfuscation API (#5486)" This reverts commit 11864ea. Revert "[2.6] MOD-7634: Fix NOSTEM (#5484)" This reverts commit 54a82e0. Revert "[2.6] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5445)" This reverts commit 3805366. Revert "Backport info metrics including index error mechanism to 2.6 [MOD-8450] (#5413)" This reverts commit eb8993c. Revert "[2.6] Fixes for inverted indexes encoding - [MOD-8248] (#5390)" This reverts commit 382bc94. Revert "[2.6] MOD-8221: backport info fields (for metrics) to 2.6 (#5375)" This reverts commit 24790ec. Revert "[2.6] Improve "Raw doc id" encoding - [MOD-8255] (#5374)" This reverts commit 778bf80. Revert "[2.6] Improve SkipToBlock logic - [MOD-8255] (#5368)" This reverts commit 775508c. Revert "[2.6][MOD-8115] Free spec resources in the main thread (#5324) (#5331)" This reverts commit fc7b1a6. Revert "[2.6] Fix Sorting Vector - [MOD-6783] (#5315)" This reverts commit 990cdcb. Revert "[2.6] Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5306)" This reverts commit 666db12. Revert "[2.6] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5302)" This reverts commit 2e0da82. Revert "[2.6] Fix missing expansions in text queries - [MOD-8142] (#5286)" This reverts commit a39acfe. Revert "[2.6] MOD-8188: Fix OnReopen Comments (#5289)" This reverts commit 4a08a98. Revert "[2.6] Fix Tag OnReopen Callback - [MOD-8011] (#5281)" This reverts commit ee4d515. Revert "[2.6] Fix MRIterator ownership mechanism - [MOD-8108] (#5270)" This reverts commit 601002a. Revert "[2.6] MOD-8129: Fix indexed_percent info stat (#5250)" This reverts commit 4dc1713. Revert "[2.6] Fix Numeric Tree Balance - [MOD-8081, MOD-8082] (#5201)" This reverts commit b331af9. Revert "[2.6] Performance improvement in indexBulkFields - [MOD-8093] (#5193)" This reverts commit 54c9ded. Revert "[2.6] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5168)" This reverts commit b86fcda. Revert "[2.6] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5107)" This reverts commit 4c09577. Revert "[2.6] Fix flaky test (#5085)" This reverts commit 8cf0465.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Fix Empty Numeric Value - [MOD-7244] (#5566) * Adding numeric check * changes * change to each one * MOD-6786 Fix search on larger then 128 terms (#5524) * Move length slicing to NOMODIFY if * add py test * fix slicing * fix test * fix text skip cluster * Adding comments * Update test_issues - skip cluster * MOD-8561: Fix Inverted Index SeekTo Edge Case (#5528) * * initial commit * * simplify the fix * * revert to old code to solve edge case * Load config params for Redis 8.0-m03 (#5538) * Load config params for Redis v7.9.226 * Add step to get latest unreleased redis tag * Remove commented-out step `Get Latest Release Tag with Prefix` * Revert: task-get-latest-tag.yml * MOD-8601: Fix error message for LOAD (#5531) * Enhance error message for LOAD * Fix error message * Address review * Fix flakiness in a test (#5541) * fix flakiness * revert whitespace change * Fix Max Frequency Misscalculation - [MOD-8158] (#5553) * fix unrelated test * add a failing test * fix issue * revert whitespace change from test_vecsim.py * revert whitespace change in test_issues.py * Fix APPLY/FILTER parser - [MOD-7804] (#5520) * fix order of operations * minor improvements to the lexer * improve functions parsing * optimize "NOT" logic and perform arithmetic operations immediately * fix flow tests * fix grammar optimization * changed function API * added a test * minor fix * fix precedence * minor improvement * reorder rule and fix leak * another fix * added test * more tests for a better coverage * improved test * fix assertion * review fixes * address code review * added comments * remove unncessary * Added tests for legacy filter empty * Adding numeric check * changes * change to each one * remove unncessary * Added tests for legacy filter empty * * Change the order of params * Add support in GEOFILTER * Forgot one file * * Changed to AC_GetString with no advance * Added comment * change the string check * PR changes * Changes * push the test * change style --------- Co-authored-by: lerman25 <[email protected]> Co-authored-by: kei-nan <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit e4d8fa0) * Change python to fit python3.7 --------- Co-authored-by: dor-forer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error message for
LOAD, which may be quite confusing when this is received: