Fix legacy geofilter leak - [MOD-8568]#5523
Merged
Conversation
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5523 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 196 196
Lines 35226 35226
=======================================
+ Hits 30722 30723 +1
+ Misses 4504 4503 -1 ☔ View full report in Codecov by Sentry. |
GuyAv46
force-pushed
the
guyav-fix_legacy_geofilter_leak_master
branch
from
42f02ac to
d089d4a
Compare
alonre24
approved these changes
Jan 22, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
* fix bug * added a test * fix typo * fix edge case leak (cherry picked from commit fdd48ae)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Fix legacy geofilter leak - [MOD-8568] (#5523) * fix bug * added a test * fix typo * fix edge case leak (cherry picked from commit fdd48ae) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix a bug when a query has multiple GEOFILTER filters. Instead of applying them all (like we do with the legacy numeric filters), we override the single filter pointer, causing a leak and also yielding wrong results.
This PR is parallel to #5516 and targeted to master and 8.0 branches.
Mark if applicable