MOD-7069: Send GC heartbeats to track copy on write behaviour#5503
Merged
DvirDukhan merged 3 commits intomasterfrom Jan 15, 2025
Merged
MOD-7069: Send GC heartbeats to track copy on write behaviour#5503DvirDukhan merged 3 commits intomasterfrom
DvirDukhan merged 3 commits intomasterfrom
Conversation
kei-nan
force-pushed
the
master_jk_report_gc_fork_cow
branch
from
124543f to
99c47ca
Compare
raz-mon
reviewed
Jan 14, 2025
Collaborator
raz-mon
left a comment
raz-mon
left a comment
There was a problem hiding this comment.
Nice
Can we see some change in the INFO response? Somewhere?
Would be nice to add a test accordingly.
… the parent process * add a mock function so tests would pass.
GuyAv46
reviewed
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5503 +/- ##
==========================================
+ Coverage 87.14% 87.18% +0.03%
==========================================
Files 196 196
Lines 35061 35110 +49
==========================================
+ Hits 30554 30610 +56
+ Misses 4507 4500 -7 ☔ View full report in Codecov by Sentry. |
GuyAv46
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5503-to-2.8 origin/2.8
cd .worktree/backport-5503-to-2.8
git switch --create backport-5503-to-2.8
git cherry-pick -x 0a5aae0361343ccc533bb56f973559b37854a501 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5503-to-2.6 origin/2.6
cd .worktree/backport-5503-to-2.6
git switch --create backport-5503-to-2.6
git cherry-pick -x 0a5aae0361343ccc533bb56f973559b37854a501 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5503-to-2.10 origin/2.10
cd .worktree/backport-5503-to-2.10
git switch --create backport-5503-to-2.10
git cherry-pick -x 0a5aae0361343ccc533bb56f973559b37854a501 |
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* * Send gc heartbeats to track copy on write behaviour * * send heartbeats more frequently to provide a more correct status to the parent process * add a mock function so tests would pass. * * add comment for the progress field (cherry picked from commit 0a5aae0)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
…5510) MOD-7069: Send GC heartbeats to track copy on write behaviour (#5503) * * Send gc heartbeats to track copy on write behaviour * * send heartbeats more frequently to provide a more correct status to the parent process * add a mock function so tests would pass. * * add comment for the progress field (cherry picked from commit 0a5aae0) Co-authored-by: kei-nan <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clear and concise description of what the PR is solving, including:
Main objects this PR modified
Mark if applicable