Skip to content

[8.0] MOD-7612: config params (#5129)#5491

Merged
nafraf merged 1 commit into8.0from
nafraf_backport-5129-to-8.0
Jan 9, 2025
Merged

[8.0] MOD-7612: config params (#5129)#5491
nafraf merged 1 commit into8.0from
nafraf_backport-5129-to-8.0

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Jan 8, 2025

Description

Manual backport of #5129 to 8.0.
(cherry picked from commit 5ca0699)

(cherry picked from commit 5ca0699)
@nafraf nafraf marked this pull request as ready for review January 8, 2025 22:30
@oshadmi oshadmi self-requested a review January 8, 2025 22:52
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 26.48649% with 136 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (6210041) to head (7664979).
Report is 3 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/config.c 25.80% 92 Missing ⚠️
src/coord/config.c 2.56% 38 Missing ⚠️
src/module.c 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #5491      +/-   ##
==========================================
- Coverage   87.56%   87.25%   -0.32%     
==========================================
  Files         196      196              
  Lines       34842    34993     +151     
==========================================
+ Hits        30510    30532      +22     
- Misses       4332     4461     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf added this pull request to the merge queue Jan 8, 2025
Merged via the queue into 8.0 with commit 839da78 Jan 9, 2025
12 of 15 checks passed
@nafraf nafraf deleted the nafraf_backport-5129-to-8.0 branch January 9, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants