[8.0] MOD-8058: Avoid error with _NUM_SSTRING#5425
Merged
Conversation
* Avoid error with _NUM_SSTRING * Fix logic * Enhance MRReply_ToValue to handle double conversion * Send doubles only in RESP3, errors in RESP2 * Fix RESP2 handling for double values * Revert "Fix RESP2 handling for double values" This reverts commit 06525f7. * Add comment --------- Co-authored-by: nafraf <[email protected]> Co-authored-by: nafraf <[email protected]> Co-authored-by: raz-mon <[email protected]> (cherry picked from commit ba6156c)
raz-mon
approved these changes
Jan 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5425 +/- ##
=======================================
Coverage 87.54% 87.55%
=======================================
Files 196 196
Lines 34813 34815 +2
=======================================
+ Hits 30478 30482 +4
+ Misses 4335 4333 -2 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5187 to
8.0.