MOD-7570: Valid safe vector index pointer access#5422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5422 +/- ##
==========================================
- Coverage 87.57% 87.56% -0.01%
==========================================
Files 196 196
Lines 34846 34856 +10
==========================================
+ Hits 30515 30521 +6
- Misses 4331 4335 +4 ☔ View full report in Codecov by Sentry. |
GuyAv46
left a comment
There was a problem hiding this comment.
Very nice
A few styling comments
alonre24
left a comment
There was a problem hiding this comment.
Looks good! only two small comments
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5422-to-2.8 origin/2.8
cd .worktree/backport-5422-to-2.8
git switch --create backport-5422-to-2.8
git cherry-pick -x aeb1d54fb324051eb8c5b97204273f658da20de7 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5422-to-2.6 origin/2.6
cd .worktree/backport-5422-to-2.6
git switch --create backport-5422-to-2.6
git cherry-pick -x aeb1d54fb324051eb8c5b97204273f658da20de7 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5422-to-2.10 origin/2.10
cd .worktree/backport-5422-to-2.10
git switch --create backport-5422-to-2.10
git cherry-pick -x aeb1d54fb324051eb8c5b97204273f658da20de7 |
* null ptr check + pytest * pytest + small fix * fix api calls, add debug test, remove field&index ft.info errors * format fixes, add pytest to debug dumpHNSW * fix kdv free * Comment change and PING after flushall (cherry picked from commit aeb1d54)
|
Successfully created backport PR for |
MOD-7570: Valid safe vector index pointer access (#5422) * null ptr check + pytest * pytest + small fix * fix api calls, add debug test, remove field&index ft.info errors * format fixes, add pytest to debug dumpHNSW * fix kdv free * Comment change and PING after flushall (cherry picked from commit aeb1d54) Co-authored-by: lerman25 <[email protected]>
Validation on vector index pointer accesses to prevent null pointer access.
Solving 2 bugs: