Conversation
* wip * WIP * Add unit-tests for the Circular Buffer * Formatting * Add coverage to itemSize * Add spaces * Add coverage for ResetReader * Address review * Fix item_count update to be atomic * Add multi-threaded cpp tests for add, reserve functions * Touchup * Format test file * Add comments and some thread-safe modifications * Fix indentation * Remove new-line * Touchup * Fix multi-threading test * Modify test * Remove comment * Add assertion for item-size and item-cap * Modify assertion * Add wasFull output variable to the reserve api * Initialize wasFull to false * Set wasFull in false case (cherry picked from commit dae453b)
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #5381 +/- ##
==========================================
+ Coverage 85.02% 85.06% +0.03%
==========================================
Files 195 196 +1
Lines 34117 34197 +80
==========================================
+ Hits 29009 29088 +79
- Misses 5108 5109 +1 ☔ View full report in Codecov by Sentry. |
raz-mon
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5297 to
2.8.