[8.0] Refactor the Numeric Tree to use HyperLogLogs - [MOD-7966, MOD-8116]#5380
Merged
[8.0] Refactor the Numeric Tree to use HyperLogLogs - [MOD-7966, MOD-8116]#5380
Conversation
…5049) * basic implementation * fix compilation * minor changes * implement split by median * more cleanup * implicit element size allocation * minor cleanups and caching 32 - bits * use standard API * revert using stdc API * added comments * typo fix * implement a simple doubles max heap * gc code cleanup and preparations * implement GC numeric fix * simplified implementation * more cleanup * more cleanup * more tidy up * minor fixes * tidy up * tidy up * minor improvement * add an assertion * add caching mechanism to HLL * minor improvements * tidy up * more cleanup and simplifications * fix tests and cleanup * remove multiplier from testNumericTree * implement minimal version of numeric tree debug print * fix tests * delete dead code * remove code duplication * address review comments * another test case * add a failing test * fix GC logic * flip ownership over flag * move some calculations to the child process * flip condition order * address review comments and start counting leaves * tidy up * review fixes * minor improvements * tidy up * address some review fixes * address some more review comments (cherry picked from commit ecb85b7)
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5380 +/- ##
==========================================
+ Coverage 86.62% 87.05% +0.43%
==========================================
Files 195 195
Lines 34768 34761 -7
==========================================
+ Hits 30118 30262 +144
+ Misses 4650 4499 -151 ☔ View full report in Codecov by Sentry. |
GuyAv46
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5049 to
8.0.