Improve "Raw doc id" encoding - [MOD-8255]#5364
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
==========================================
+ Coverage 86.50% 86.63% +0.12%
==========================================
Files 195 195
Lines 34818 34809 -9
==========================================
+ Hits 30120 30157 +37
+ Misses 4698 4652 -46 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Dec 18, 2024
GuyAv46
changed the title
Contributor
|
Successfully created backport PR for |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5364-to-2.6 origin/2.6
cd .worktree/backport-5364-to-2.6
git switch --create backport-5364-to-2.6
git cherry-pick -x 565633a1ea57cf5284f3b67cb84cde61a608f8bd |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) * fix API for old version --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) * fix API for old version --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
GuyAv46
added a commit
that referenced
this pull request
Feb 4, 2025
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change
GuyAv46
added a commit
that referenced
this pull request
Feb 5, 2025
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
GuyAv46
added a commit
that referenced
this pull request
Feb 5, 2025
* Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Revert inverted index iterator changes (#5596) * Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d) * fix test for 2.6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Revert inverted index iterator changes (#5596) * Revert "[2.10] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5536)" This reverts commit f9923b7. * Revert "[2.10] Improve SkipToBlock logic - [MOD-8255] (#5370)" This reverts commit 56b16ea. * partial revert of #5364 * address CR, added tests * test improvement * Improve test and fix bug (remove revert) * remove temporary change (cherry picked from commit 8d3282d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up of #5350
This PR fixes the raw doc ID seeker logic, by removing a previous workaround required by the bug fixed in #5350.
It also enables the raw doc id configuration in the coverage flow, for a more accurate coverage report.
Main objects this PR modified
Mark if applicable