Skip to content

[2.8] MOD-8221: backport info fields (for metrics) to 2.8#5358

Merged
oshadmi merged 6 commits into2.8from
oshadmi_backport-info-fields-4metrics-to-2.8
Dec 19, 2024
Merged

[2.8] MOD-8221: backport info fields (for metrics) to 2.8#5358
oshadmi merged 6 commits into2.8from
oshadmi_backport-info-fields-4metrics-to-2.8

Conversation

@oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Dec 17, 2024

Backport #4640 #4590 #4561
And #5146
to 2.8

MOD-8221
(adding info fields)

(cherry picked from commit 73e717f)

(cherry picked from commit 71a4af2)

(cherry picked from commit 6a2c6fa)
@oshadmi oshadmi changed the base branch from master to 2.8 December 17, 2024 05:25
…4590)

* Replace average cycle time with total time

* Change INFO field name to correspond to FT.INFO field name

(cherry picked from commit 71a4af2)
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (fb4cee0) to head (fc49e7a).
Report is 4 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/redisearch_api.c 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #5358      +/-   ##
==========================================
+ Coverage   84.87%   84.90%   +0.03%     
==========================================
  Files         195      195              
  Lines       34075    34120      +45     
==========================================
+ Hits        28920    28970      +50     
+ Misses       5155     5150       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oshadmi oshadmi requested a review from raz-mon December 17, 2024 14:40
Copy link
Collaborator

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
One comment

@oshadmi oshadmi requested a review from raz-mon December 17, 2024 17:39
raz-mon
raz-mon previously approved these changes Dec 18, 2024
@oshadmi oshadmi added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
Copy link
Collaborator

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to add the changes to rocky_linux_8.sh to other versions as well

@oshadmi oshadmi added this pull request to the merge queue Dec 19, 2024
Merged via the queue into 2.8 with commit b7eaa56 Dec 19, 2024
@oshadmi oshadmi deleted the oshadmi_backport-info-fields-4metrics-to-2.8 branch December 19, 2024 13:08
kei-nan added a commit that referenced this pull request Jan 30, 2025
kei-nan added a commit that referenced this pull request Jan 30, 2025
This reverts commit ef25dca.

Revert "[2.8] Fix Max Frequency Misscalculation - [MOD-8158] (#5560)"

This reverts commit a6864e3.

Revert "[2.8] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5542)"

This reverts commit bb873af.

Revert "[2.8] Fix legacy geofilter leak - [MOD-8568] (#5518)"

This reverts commit 979f3d2.

Revert "Backport 4243 to 2.8 (#5508)"

This reverts commit 9af7959.

Revert "MOD-7570 Backport 5422 to 2.8 (#5470)"

This reverts commit 540b5f3.

Revert "[2.8] MOD-7872: Add Types To Hide User Input (#5489)"

This reverts commit b2bf242.

Revert "[2.8] MOD-7864: Obfuscation API (#5488)"

This reverts commit 4866bf1.

Revert "[2.8] MOD-7634: Fix NOSTEM  (#5475)"

This reverts commit a015a55.

Revert "[2.8] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5444)"

This reverts commit baadb4d.

Revert "[2.8] MOD-8058: Avoid error with _NUM_SSTRING (#5187) (#5427)"

This reverts commit 5b49276.

Revert "Backport metrics info 2.8 [MOD-8388] (#5407)"

This reverts commit f428033.

Revert " [2.8] Fixes for inverted indexes encoding - [MOD-8248] (#5389)"

This reverts commit 0c7227e.

Revert "[2.8] MOD-8221: backport info fields (for metrics) to 2.8 (#5358)"

This reverts commit b7eaa56.

Revert "[2.8] Improve "Raw doc id" encoding - [MOD-8255] (#5371)"

This reverts commit 152043b.

Revert "[2.8] Improve SkipToBlock logic - [MOD-8255] (#5369)"

This reverts commit c1a2c8f.

Revert "[2.8][MOD-8115] Free spec resources in the main thread (#5324) (#5330)"

This reverts commit 5f3ce64.

Revert "[2.8] Fix Sorting Vector - [MOD-6783] (#5316)"

This reverts commit 04f7778.

Revert "[2.8] Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5305)"

This reverts commit 4fc1b27.

Revert "[MOD-7949] Avoid lazy expire upon scan keys in background [2.8] (#5303)"

This reverts commit 16e4ff4.

Revert "[2.8] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5299)"

This reverts commit 09f5b62.

Revert "[2.8] Remove assertion in optimizer (#5296)"

This reverts commit 45db16a.

Revert "[2.8] MOD-8188: Fix OnReopen Comments (#5288)"

This reverts commit 001746f.

Revert "[2.8] Fix missing expansions in text queries - [MOD-8142] (#5287)"

This reverts commit ed13507.

Revert "[2.8] Fix Tag OnReopen Callback - [MOD-8011] (#5280)"

This reverts commit 40b8012.

Revert "[2.8] Fix MRIterator ownership mechanism - [MOD-8108] (#5269)"

This reverts commit 90a5685.

Revert "[2.8] [MOD-8125] Create inverted index in write operations only (#5260)"

This reverts commit ebb9484.

Revert "[2.8] MOD-8129: Fix indexed_percent info stat (#5249)"

This reverts commit fb9781a.

Revert "[2.8] MOD-8097, MOD-8114 Fix memory counting (#5242)"

This reverts commit a21a909.

Revert "[2.8] Cleanup for the trimming tree logic (#5225)"

This reverts commit 1b9126b.

Revert "[2.8] [MOD-8035] Add field index error for JSON field indexing failures (#5205)"

This reverts commit 3a13ddb.

Revert "[2.8] Fix Numeric Tree Balance - [MOD-8081, MOD-8082] (#5200)"

This reverts commit a2948c4.

Revert "[2.8] Performance improvement in indexBulkFields - [MOD-8093] (#5192)"

This reverts commit 2b0e0a0.

Revert "[2.8] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5167)"

This reverts commit f860505.

Revert "[2.8] Skip test_multithread:test_async_updates_sanity with sanitizer  (#5124)"

This reverts commit 938369a.

Revert "[2.8] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5108)"

This reverts commit ba614ca.

Revert "[2.8] Fix flaky test (#5084)"

This reverts commit f579156.

Revert "[2.8] Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5080)"

This reverts commit 1a0eabc.

Revert "[2.8] Handle VecSim in-place deletion after async [MOD-7643, MOD-7732] (#5048)"

This reverts commit fcc19e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants