Improve counting active writes - [MOD-8151]#5354
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5354 +/- ##
==========================================
- Coverage 86.50% 86.50% -0.01%
==========================================
Files 195 195
Lines 34817 34821 +4
==========================================
+ Hits 30120 30123 +3
- Misses 4697 4698 +1 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Dec 17, 2024
| size_t num_active_indexes_querying; // Number of active read indexes | ||
| size_t num_active_indexes_indexing; // Number of active write indexes | ||
| size_t total_active_writes; // Total number of active writes | ||
| size_t total_active_writes; // Total number of active writes (proportional to the number of threads) |
Collaborator
There was a problem hiding this comment.
Suggested change
| size_t total_active_writes; // Total number of active writes (proportional to the number of threads) | |
| size_t total_active_writes; // Total number of threads actively writing to some index |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* improve counting active writes * add a test (cherry picked from commit 2b5182d)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* improve counting active writes * add a test (cherry picked from commit 2b5182d)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Improve counting active writes - [MOD-8151] (#5354) * improve counting active writes * add a test (cherry picked from commit 2b5182d) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Improve counting active writes - [MOD-8151] (#5354) * improve counting active writes * add a test (cherry picked from commit 2b5182d) Co-authored-by: GuyAv46 <[email protected]>
alonre24
pushed a commit
that referenced
this pull request
Dec 27, 2024
Improve counting active writes - [MOD-8151] (#5354) * improve counting active writes * add a test (cherry picked from commit 2b5182d) Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit a3d447d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 1, 2025
* CP Count Queries - [MOD-6492] * [2.10] Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5146) Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143) * implement min and max memory usage metrics * added to info module test (cherry picked from commit b0d56ad) Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 094318f) * [2.10] Add a counter of total query execution time - [MOD-7961] (#5153) * Add a counter of total query execution time - [MOD-7961] (#5145) * complete CP of "Count Queries" (#5072) content * always count query execution time (on non-internal commands) * add test * give more time * review fixes (cherry picked from commit 97f34e2) * add missing if (cherry picked from commit d45365d) * CP [MOD-8034] expose indexing failures to INFO modules * [2.10] Add VecSim related metrics - [MOD-7967] (#5169) Add VecSim related metrics - [MOD-7967] (#5151) * added vector info * added a test * drain work queue before checking memory * move vector metrics info field statistics section * fix test * fix test * tidy up * added a flat index to the test (cherry picked from commit 388f81e) Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit 242f314) * CP Add Active Indices Metrics - [MOD-7952] * CP Add global marked deleted to stats [MOD-6053] * CP Fork gc code cleanup (PR #4263) to enable GC mechanism that will allow the test of marked deleted info to pass * CP [MOD-8152] rename and move new metrics * CP [MOD-8035] Add field index error for JSON field indexing failures * CP [MOD-8039] Reorganize stats files * [2.10] Improve counting active writes - [MOD-8151] (#5362) Improve counting active writes - [MOD-8151] (#5354) * improve counting active writes * add a test (cherry picked from commit 2b5182d) Co-authored-by: GuyAv46 <[email protected]> (cherry picked from commit a3d447d) * Update mem usage computation to align to 2.10 * revert bad additions (CR) * revert bad additions (CR) 2 * Better memory check in info vecsim (since mac failed) * Fix syntax error --------- Co-authored-by: redisearch-backport-pull-request[bot] <182669528+redisearch-backport-pull-request[bot]@users.noreply.github.com> Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: meiravgri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix the following metrics calculations, to address background indexing:
total_active_writesnow counts the BG indexer thread as well.num_active_indexes_indexingandnum_active_indexesnow count all indexes that currently index data or waiting for a BG indexing processMark if applicable