[8.0] [MOD-8039] Reorganize stats files#5351
Merged
Conversation
* new file : info/INFO_MODULES responsible to expose all aggregated shard stats to INFO command move RS_moduleInfoFunc from module-init to move all add to info functions to a dedicated file: from global_stats.c FieldsGlobalStats_AddToInfo TotalGlobalStats_Queries_AddToInfo DialectsGlobalStats_AddToInfo IndexesGlobalStats_AddToInfo from config.c: RSConfig_AddToInfo introduce FieldsGlobalStats_GetIndexError to expose fields errors move queries stats from TotalGlobalStats to seperate struct QueriesGlobalStats * rediSearchAPI::RediSearch_TotalInfo calls IndexesInfo_TotalInfo from indexes_info IndexesInfo_TotalInfo (orignally rediSearchAPI::RediSearch_TotalInfo) calls IndexSpec_TotalMemUsage instead of rediSearchAPI::RediSearch_TotalMemUsage introduce indexes_info rename TotalSpecsFieldInfo and TotalSpecsInfo: specs->indexes move TotalIndexesFieldsInfo and TotalIndexesInfo from info_command to indexes_info move global stats to info dir move info_command to info dir introduce util/units. A file for all macros handling shared units conversion remove CLOCKS_PER_MILLISEC from profile.h, include util/units.h instead add a cpp test for llapi indexes info * release index remove unused header from module-init * remove TODO * review fixes rename INFO_MODULES->info_redis rename MEMORY_HUMAN->MEMORY_MB (cherry picked from commit 175d787)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5351 +/- ##
==========================================
+ Coverage 86.55% 86.57% +0.02%
==========================================
Files 192 194 +2
Lines 34467 34511 +44
==========================================
+ Hits 29834 29879 +45
+ Misses 4633 4632 -1 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5329 to
8.0.