Improve SkipToBlock logic - [MOD-8255]#5350
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5350 +/- ##
==========================================
+ Coverage 86.49% 86.52% +0.03%
==========================================
Files 193 195 +2
Lines 34773 34809 +36
==========================================
+ Hits 30076 30119 +43
+ Misses 4697 4690 -7 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Dec 17, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5350-to-2.8 origin/2.8
cd .worktree/backport-5350-to-2.8
git switch --create backport-5350-to-2.8
git cherry-pick -x 27870fedbe22ebc6ac288c3c05045342aba05fd0 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5350-to-2.6 origin/2.6
cd .worktree/backport-5350-to-2.6
git switch --create backport-5350-to-2.6
git cherry-pick -x 27870fedbe22ebc6ac288c3c05045342aba05fd0 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5350-to-2.10 origin/2.10
cd .worktree/backport-5350-to-2.10
git switch --create backport-5350-to-2.10
git cherry-pick -x 27870fedbe22ebc6ac288c3c05045342aba05fd0 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix skip to block logic * fix seekRawDocIdsOnly * another cleanup * remove dead code * more dead code removal * small fix * revert seeker fix (moved to another PR) (cherry picked from commit 27870fe)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Improve SkipToBlock logic - [MOD-8255] (#5350) * fix skip to block logic * fix seekRawDocIdsOnly * another cleanup * remove dead code * more dead code removal * small fix * revert seeker fix (moved to another PR) (cherry picked from commit 27870fe) Co-authored-by: GuyAv46 <[email protected]>
2 tasks
GuyAv46
added a commit
that referenced
this pull request
Dec 18, 2024
* fix skip to block logic * fix seekRawDocIdsOnly * another cleanup * remove dead code * more dead code removal * small fix * revert seeker fix (moved to another PR) (cherry picked from commit 27870fe)
GuyAv46
added a commit
that referenced
this pull request
Dec 18, 2024
* fix skip to block logic * fix seekRawDocIdsOnly * another cleanup * remove dead code * more dead code removal * small fix * revert seeker fix (moved to another PR) (cherry picked from commit 27870fe)
GuyAv46
added a commit
that referenced
this pull request
Dec 18, 2024
* fix skip to block logic * fix seekRawDocIdsOnly * another cleanup * remove dead code * more dead code removal * small fix * revert seeker fix (moved to another PR) (cherry picked from commit 27870fe)
This was referenced Dec 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test
GuyAv46
added a commit
that referenced
this pull request
Dec 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) * fix API for old version --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Improve "Raw doc id" encoding (#5364) * steal seeker fix from #5350 * try running RAW_DOCID_ENCODING with coverage * [TEMP] disable skip on QUICK=1 * Revert temporary changes * add a unit test (cherry picked from commit 565633a) * fix API for old version --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
2 tasks
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix the
IndexReader_SkipToBlocklogic to always set the current block as the first one containing a document with an ID greater or equal to the one we search for.In some edge cases, we may have set the current block to the one before the next relevant block, causing an additional full block scan before we find the next relevant result.
This issue also causes an unexpected out-of-range case in the
seekRawDocIdsOnlyskipper, which assumes we are currently at the right block.Main objects this PR modified
IndexReader_SkipToBlockMark if applicable