Improve text indexing performance - [MOD-8249]#5348
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 86.49% 86.49%
=======================================
Files 193 193
Lines 34773 34774 +1
=======================================
+ Hits 30076 30077 +1
Misses 4697 4697 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Dec 15, 2024
Collaborator
alonre24
left a comment
alonre24
left a comment
There was a problem hiding this comment.
Nice catch, @fcostaoliveira how hard will it be to add a new dataset to our benchmarks that shows the performance difference in this use case (load long text docs)?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
remove strlen calls (cherry picked from commit ab3628d)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
remove strlen calls (cherry picked from commit ab3628d)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
Improve text indexing performance - [MOD-8249] (#5348) remove strlen calls (cherry picked from commit ab3628d) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
Improve text indexing performance - [MOD-8249] (#5348) remove strlen calls (cherry picked from commit ab3628d) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Removing redundant calls to
strlenthat may slow text field indexing.This PR doesn't have any new tests, as it doesn't introduce new logic. The fact that all the current tests pass is all the validation we need.
Mark if applicable