Fixes for inverted indexes encoding - [MOD-8248]#5347
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
+ Coverage 87.06% 87.54% +0.47%
==========================================
Files 195 196 +1
Lines 34802 34740 -62
==========================================
+ Hits 30302 30414 +112
+ Misses 4500 4326 -174 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Dec 16, 2024
oshadmi
reviewed
Dec 16, 2024
alonre24
reviewed
Dec 19, 2024
alonre24
previously approved these changes
Dec 19, 2024
alonre24
approved these changes
Dec 19, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5347-to-2.8 origin/2.8
cd .worktree/backport-5347-to-2.8
git switch --create backport-5347-to-2.8
git cherry-pick -x c03c15af98d8beb46512273a3ba9e64ad4058e25 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5347-to-2.6 origin/2.6
cd .worktree/backport-5347-to-2.6
git switch --create backport-5347-to-2.6
git cherry-pick -x c03c15af98d8beb46512273a3ba9e64ad4058e25 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5347-to-2.10 origin/2.10
cd .worktree/backport-5347-to-2.10
git switch --create backport-5347-to-2.10
git cherry-pick -x c03c15af98d8beb46512273a3ba9e64ad4058e25 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
Fixes for inverted indexes encoding - [MOD-8248] (#5347) * code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a) Co-authored-by: GuyAv46 <[email protected]>
GuyAv46
added a commit
that referenced
this pull request
Dec 20, 2024
* code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a)
GuyAv46
added a commit
that referenced
this pull request
Dec 20, 2024
* code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a)
GuyAv46
added a commit
that referenced
this pull request
Dec 20, 2024
* code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a)
GuyAv46
added a commit
that referenced
this pull request
Dec 20, 2024
* code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a)
This was referenced Dec 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2024
* Fixes for inverted indexes encoding - [MOD-8248] (#5347) * code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a) * fix test for 2.6 * more fixes for 2.6 * another 2.6 fix * final fixes for 2.6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2024
* Fixes for inverted indexes encoding - [MOD-8248] (#5347) * code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a) * fixes for 2.8 * final fix for 2.8 * build fix for 2.8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2024
* Fixes for inverted indexes encoding - [MOD-8248] (#5347) * code cleanup * fix numeric encoding * fix unit-tests * fix flow tests * cleanup * fix type * minor cleanup * some more cleanup * simplify repair flow * review fixes * improve test to include all flags * minor changes and cleanup * added a sanity test (cherry picked from commit c03c15a) * final fixes for 2.10 * fix test for 2.10
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
While it was assumed the numeric encoder can encode any
doc_iddiff (while other encoders cannot encode delta >UINT32_MAX), all the encoders got auint32_tdelta, so the numeric encoder will not encode the right delta, causing later unrelated results to be returned.The encoder also cannot encode any delta, but only deltas that fit in 7 bytes, due to the numeric header byte count limitation (counting 0-7 with 3 bits). We now also validate that before attempting to encode the delta, and creating a new block if needed.
Which additional issues this PR fixes
Mark if applicable