Skip to content

[8.0] MOD-7976: Fix HFE Regression#5336

Merged
kei-nan merged 1 commit intobackport-4858-to-8.0from
backport-5318-to-8.0
Dec 10, 2024
Merged

[8.0] MOD-7976: Fix HFE Regression#5336
kei-nan merged 1 commit intobackport-4858-to-8.0from
backport-5318-to-8.0

Conversation

@kei-nan
Copy link
Collaborator

@kei-nan kei-nan commented Dec 10, 2024

Manual backport of #5318

* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used

* * update sdk to get new hash field expiration API

* * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire`

* * skip field expiration tests if below 8.0 API

* * Code Review Comments
* Prevent turning on the monitorFieldExpiration if the API does not exist

* * move to run against redis 8.0

(cherry picked from commit bebdeb7)
@kei-nan kei-nan changed the base branch from master to backport-4858-to-8.0 December 10, 2024 14:57
@kei-nan kei-nan changed the title Backport 5318 to 8.0 [8.0] MOD-7976: Fix HFE Regression Dec 10, 2024
@kei-nan kei-nan merged commit 2f5b065 into backport-4858-to-8.0 Dec 10, 2024
@kei-nan kei-nan deleted the backport-5318-to-8.0 branch December 10, 2024 14:58
kei-nan added a commit that referenced this pull request Dec 10, 2024
MOD-7976: Fix HFE Regression (#5318)

* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used

* * update sdk to get new hash field expiration API

* * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire`

* * skip field expiration tests if below 8.0 API

* * Code Review Comments
* Prevent turning on the monitorFieldExpiration if the API does not exist

* * move to run against redis 8.0

(cherry picked from commit bebdeb7)
kei-nan added a commit that referenced this pull request Dec 10, 2024
MOD-7976: Fix HFE Regression (#5318)

* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used

* * update sdk to get new hash field expiration API

* * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire`

* * skip field expiration tests if below 8.0 API

* * Code Review Comments
* Prevent turning on the monitorFieldExpiration if the API does not exist

* * move to run against redis 8.0

(cherry picked from commit bebdeb7)
kei-nan added a commit that referenced this pull request Dec 11, 2024
MOD-7976: Fix HFE Regression (#5318)

* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used

* * update sdk to get new hash field expiration API

* * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire`

* * skip field expiration tests if below 8.0 API

* * Code Review Comments
* Prevent turning on the monitorFieldExpiration if the API does not exist

* * move to run against redis 8.0

(cherry picked from commit bebdeb7)
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
…returning them as valid results (#5118)

* MOD-7329: Determine if fields and documents are expired before returning them as valid results (#4858)

* * initial commit

* * fix missing case in test_expire.py

* * fix coord compilation

* * fix doc info test

* * try and fix some of the tests

* * release iterator

* * do not set expiration time in the context of the coordinator since it doesn't have an index spec

* * support c++ tests that do not provide spec for iterators

* * no point in passing timestamp in coordinator flow

* * redis 7.4 version in ci is actually 7.3, for codecov we need our tests to run

* * reduce max memory from + 200000 to 150000

* * fix test

* * cleanup code

* * Code Review: Round #1

* * Add geoshape tests, only pass index instead of pointer to filter ctx

* * Add vector test

* * Code Review - Round #2

* * try and fix tests

* * Code Review - Round #3

* * Fix Sanitizer Build

* * Code Review - Round #4

* * Minor change in debug command SET_MONITOR_EXPIRATION

* * Code Review - Round #5

* * fix tests

* * Code Review - Round #6

* * fix crash

* * fix test

* * improve field mask translation time

* fix compilation

* fix compilation error

* handle field mask of 64 bit

* * Code Review - Round #7

* * fix opening of key edge cases

* * free fieldIdToIndex array

* Code Review - Round #9

* * fix rebase conflicts
* support wild card reader filtering

* * mac os: fallback to CLOCK_REALTIME if CLOCK_REALTIME_COARSE is not defined

(cherry picked from commit 4a67a87)

* MOD-7979: Protect Against RS_FIELDMASK_ALL Mask Edge Case (#5128)

* * check mask edge case

* * Code Review - Round #1

(cherry picked from commit 2c037bc)

* [8.0] MOD-7976: Fix HFE Regression (#5336)

MOD-7976: Fix HFE Regression (#5318)

* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used

* * update sdk to get new hash field expiration API

* * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire`

* * skip field expiration tests if below 8.0 API

* * Code Review Comments
* Prevent turning on the monitorFieldExpiration if the API does not exist

* * move to run against redis 8.0

(cherry picked from commit bebdeb7)

* * rebase fixes

* * add REDISMODULE_OPEN_KEY_NOEFFECTS to OpenKey when loading json document

* * fix for test_debug_commands.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant