Merged
Conversation
kei-nan
requested review from
oshadmi and
raz-mon
and removed request for
raz-mon
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
==========================================
- Coverage 86.72% 86.62% -0.11%
==========================================
Files 193 193
Lines 34704 34681 -23
==========================================
- Hits 30097 30041 -56
- Misses 4607 4640 +33 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Dec 9, 2024
oshadmi
previously approved these changes
Dec 9, 2024
…when expiration isn't being used
…Module_HashFieldMinExpire`
* Prevent turning on the monitorFieldExpiration if the API does not exist
kei-nan
force-pushed
the
master_jk_fix_hfe_regression
branch
from
4ff16d5 to
bf62df6
Compare
oshadmi
approved these changes
Dec 10, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5318-to-2.10 origin/2.10
cd .worktree/backport-5318-to-2.10
git switch --create backport-5318-to-2.10
git cherry-pick -x bebdeb70a2437266a09b5bdf1f86f3b3ae701a2b |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5318-to-8.0 origin/8.0
cd .worktree/backport-5318-to-8.0
git switch --create backport-5318-to-8.0
git cherry-pick -x bebdeb70a2437266a09b5bdf1f86f3b3ae701a2b |
kei-nan
added a commit
that referenced
this pull request
Dec 10, 2024
* * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
kei-nan
added a commit
that referenced
this pull request
Dec 10, 2024
MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
kei-nan
added a commit
that referenced
this pull request
Dec 10, 2024
MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
kei-nan
added a commit
that referenced
this pull request
Dec 10, 2024
MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
kei-nan
added a commit
that referenced
this pull request
Dec 11, 2024
MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
…returning them as valid results (#5118) * MOD-7329: Determine if fields and documents are expired before returning them as valid results (#4858) * * initial commit * * fix missing case in test_expire.py * * fix coord compilation * * fix doc info test * * try and fix some of the tests * * release iterator * * do not set expiration time in the context of the coordinator since it doesn't have an index spec * * support c++ tests that do not provide spec for iterators * * no point in passing timestamp in coordinator flow * * redis 7.4 version in ci is actually 7.3, for codecov we need our tests to run * * reduce max memory from + 200000 to 150000 * * fix test * * cleanup code * * Code Review: Round #1 * * Add geoshape tests, only pass index instead of pointer to filter ctx * * Add vector test * * Code Review - Round #2 * * try and fix tests * * Code Review - Round #3 * * Fix Sanitizer Build * * Code Review - Round #4 * * Minor change in debug command SET_MONITOR_EXPIRATION * * Code Review - Round #5 * * fix tests * * Code Review - Round #6 * * fix crash * * fix test * * improve field mask translation time * fix compilation * fix compilation error * handle field mask of 64 bit * * Code Review - Round #7 * * fix opening of key edge cases * * free fieldIdToIndex array * Code Review - Round #9 * * fix rebase conflicts * support wild card reader filtering * * mac os: fallback to CLOCK_REALTIME if CLOCK_REALTIME_COARSE is not defined (cherry picked from commit 4a67a87) * MOD-7979: Protect Against RS_FIELDMASK_ALL Mask Edge Case (#5128) * * check mask edge case * * Code Review - Round #1 (cherry picked from commit 2c037bc) * [8.0] MOD-7976: Fix HFE Regression (#5336) MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7) * * rebase fixes * * add REDISMODULE_OPEN_KEY_NOEFFECTS to OpenKey when loading json document * * fix for test_debug_commands.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Use new expiration API to avoid regression issues with HFE support when expiration isn't being used
RM_Callwas expensive and as a result our indexing took a hit even when expiration isn't usedMain objects this PR modified
Mark if applicable