Skip to content

[2.6] Fix Sorting Vector - [MOD-6783]#5315

Merged
GuyAv46 merged 4 commits into2.6from
backport-5311-to-2.6
Dec 5, 2024
Merged

[2.6] Fix Sorting Vector - [MOD-6783]#5315
GuyAv46 merged 4 commits into2.6from
backport-5311-to-2.6

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Dec 5, 2024

Description

Backport of #5311 to 2.6.

* refactor sortable fields

* fix tests

* make more memory efficient

* added a test

* remove unused function

* improve test

* added a comment

(cherry picked from commit 47dd9d0)
@GuyAv46 GuyAv46 added the bug label Dec 5, 2024
@GuyAv46 GuyAv46 requested a review from DvirDukhan December 5, 2024 11:44
@GuyAv46 GuyAv46 enabled auto-merge December 5, 2024 11:44
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.96%. Comparing base (666db12) to head (6f1fa02).
Report is 1 commits behind head on 2.6.

Files with missing lines Patch % Lines
src/document.c 33.33% 2 Missing ⚠️
src/sortable.c 90.00% 1 Missing ⚠️
src/spec.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #5315      +/-   ##
==========================================
+ Coverage   83.93%   83.96%   +0.02%     
==========================================
  Files         178      178              
  Lines       31147    31079      -68     
==========================================
- Hits        26144    26096      -48     
+ Misses       5003     4983      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into 2.6 with commit 990cdcb Dec 5, 2024
@GuyAv46 GuyAv46 deleted the backport-5311-to-2.6 branch December 5, 2024 14:21
raz-mon added a commit that referenced this pull request Jan 30, 2025
This reverts commit 2ea41bf.

Revert "[2.6] Fix Max Frequency Misscalculation - [MOD-8158] (#5559)"

This reverts commit 7e0288d.

Revert "[2.6] Fix flakiness in a test - [MOD-8611] (#5546)"

This reverts commit 1a43260.

Revert "[2.6] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5543)"

This reverts commit 1c2be01.

Revert "Backport 4243 to 2.6 (#5509)"

This reverts commit 5d90c3b.

Revert "[2.6] Fix legacy geofilter leak - [MOD-8568] (#5519)"

This reverts commit 221f139.

Revert "MOD-7570 Backport 5422 to 2.6 (#5473)"

This reverts commit a0f9d4b.

Revert "[2.6] MOD-7864: Obfuscation API (#5486)"

This reverts commit 11864ea.

Revert "[2.6] MOD-7634: Fix NOSTEM  (#5484)"

This reverts commit 54a82e0.

Revert "[2.6] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5445)"

This reverts commit 3805366.

Revert "Backport info metrics including index error mechanism to 2.6 [MOD-8450] (#5413)"

This reverts commit eb8993c.

Revert "[2.6] Fixes for inverted indexes encoding - [MOD-8248] (#5390)"

This reverts commit 382bc94.

Revert "[2.6] MOD-8221: backport info fields (for metrics) to 2.6 (#5375)"

This reverts commit 24790ec.

Revert "[2.6] Improve "Raw doc id" encoding - [MOD-8255] (#5374)"

This reverts commit 778bf80.

Revert "[2.6] Improve SkipToBlock logic - [MOD-8255] (#5368)"

This reverts commit 775508c.

Revert "[2.6][MOD-8115] Free spec resources in the main thread (#5324) (#5331)"

This reverts commit fc7b1a6.

Revert "[2.6] Fix Sorting Vector - [MOD-6783] (#5315)"

This reverts commit 990cdcb.

Revert "[2.6] Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5306)"

This reverts commit 666db12.

Revert "[2.6] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5302)"

This reverts commit 2e0da82.

Revert "[2.6] Fix missing expansions in text queries - [MOD-8142] (#5286)"

This reverts commit a39acfe.

Revert "[2.6] MOD-8188: Fix OnReopen Comments (#5289)"

This reverts commit 4a08a98.

Revert "[2.6] Fix Tag OnReopen Callback - [MOD-8011] (#5281)"

This reverts commit ee4d515.

Revert "[2.6] Fix MRIterator ownership mechanism - [MOD-8108] (#5270)"

This reverts commit 601002a.

Revert "[2.6] MOD-8129: Fix indexed_percent info stat (#5250)"

This reverts commit 4dc1713.

Revert "[2.6] Fix Numeric Tree Balance - [MOD-8081, MOD-8082] (#5201)"

This reverts commit b331af9.

Revert "[2.6] Performance improvement in indexBulkFields - [MOD-8093] (#5193)"

This reverts commit 54c9ded.

Revert "[2.6] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5168)"

This reverts commit b86fcda.

Revert "[2.6] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5107)"

This reverts commit 4c09577.

Revert "[2.6] Fix flaky test (#5085)"

This reverts commit 8cf0465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants