Skip to content

[8.0] Fix Sorting Vector - [MOD-6783]#5313

Merged
GuyAv46 merged 2 commits into8.0from
backport-5311-to-8.0
Dec 5, 2024
Merged

[8.0] Fix Sorting Vector - [MOD-6783]#5313
GuyAv46 merged 2 commits into8.0from
backport-5311-to-8.0

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Dec 5, 2024

Description

Backport of #5311 to 8.0.

GuyAv46 and others added 2 commits December 5, 2024 13:27
* refactor sortable fields

* fix tests

* make more memory efficient

* added a test

* remove unused function

* improve test

* added a comment

(cherry picked from commit 47dd9d0)
@GuyAv46 GuyAv46 added the bug label Dec 5, 2024
@GuyAv46 GuyAv46 requested a review from DvirDukhan December 5, 2024 11:44
@GuyAv46 GuyAv46 enabled auto-merge December 5, 2024 11:44
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (a9b5be5) to head (c73da1b).
Report is 1 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/document.c 33.33% 2 Missing ⚠️
src/sortable.c 90.00% 1 Missing ⚠️
src/spec.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #5313      +/-   ##
==========================================
+ Coverage   86.67%   86.70%   +0.03%     
==========================================
  Files         192      192              
  Lines       34477    34412      -65     
==========================================
- Hits        29882    29837      -45     
+ Misses       4595     4575      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into 8.0 with commit c6e49be Dec 5, 2024
@GuyAv46 GuyAv46 deleted the backport-5311-to-8.0 branch December 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants