Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5311 +/- ##
==========================================
+ Coverage 86.69% 86.72% +0.02%
==========================================
Files 193 193
Lines 34764 34704 -60
==========================================
- Hits 30139 30096 -43
+ Misses 4625 4608 -17 ☔ View full report in Codecov by Sentry. |
DvirDukhan
approved these changes
Dec 5, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5311-to-2.8 origin/2.8
cd .worktree/backport-5311-to-2.8
git switch --create backport-5311-to-2.8
git cherry-pick -x 47dd9d05f8be6a56722d627106713d320dd9278b |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5311-to-2.6 origin/2.6
cd .worktree/backport-5311-to-2.6
git switch --create backport-5311-to-2.6
git cherry-pick -x 47dd9d05f8be6a56722d627106713d320dd9278b |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5311-to-2.10 origin/2.10
cd .worktree/backport-5311-to-2.10
git switch --create backport-5311-to-2.10
git cherry-pick -x 47dd9d05f8be6a56722d627106713d320dd9278b |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5311-to-8.0 origin/8.0
cd .worktree/backport-5311-to-8.0
git switch --create backport-5311-to-8.0
git cherry-pick -x 47dd9d05f8be6a56722d627106713d320dd9278b |
GuyAv46
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor sortable fields * fix tests * make more memory efficient * added a test * remove unused function * improve test * added a comment (cherry picked from commit 47dd9d0)
GuyAv46
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor sortable fields * fix tests * make more memory efficient * added a test * remove unused function * improve test * added a comment (cherry picked from commit 47dd9d0)
GuyAv46
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor sortable fields * fix tests * make more memory efficient * added a test * remove unused function * improve test * added a comment (cherry picked from commit 47dd9d0)
GuyAv46
added a commit
that referenced
this pull request
Dec 5, 2024
* refactor sortable fields * fix tests * make more memory efficient * added a test * remove unused function * improve test * added a comment (cherry picked from commit 47dd9d0)
This was referenced Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring our sortable fields metadata structures
This PR fixes a bug affecting indexes with more than 255 sortable fields.
The issue happened due to storing the length of the sorting vector in an
unsigned char, which can only count to 255. We should support 1024 sortable fields so we need at least 10 bits for the length.This PR also removes the
RSSortingTablestructure from the spec, as it is very redundant - consumes additional memory and performs string comparisons for info available in theFieldSpec. it is replaced by a counter to track the current number of sortable fields.Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable