Fix a flakiness in testCursorOnCoordinator - [MOD-8016]#5304
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5304 +/- ##
=======================================
Coverage 86.69% 86.70%
=======================================
Files 193 193
Lines 34764 34764
=======================================
+ Hits 30139 30141 +2
+ Misses 4625 4623 -2 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Dec 4, 2024
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
fix flakiness (cherry picked from commit 1d81852)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
fix flakiness (cherry picked from commit 1d81852)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
fix flakiness (cherry picked from commit 1d81852)
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
fix flakiness (cherry picked from commit 1d81852)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5304) fix flakiness (cherry picked from commit 1d81852) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5304) fix flakiness (cherry picked from commit 1d81852) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5304) fix flakiness (cherry picked from commit 1d81852) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5304) fix flakiness (cherry picked from commit 1d81852) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix flakiness in the
testCursorOnCoordinatortest where we request the next 100-results chunk of results before the local_FT.AGGREGATEcommand is executed.This is not a bug, as we may get the first results from another shard and request more before the local command is triggered asynchronously.
The solution is to skip any
FT.AGGREGATEcommand (user or internal) from the monitor, as they are unrelated to the verifications we make according to the monitor. We still validate we got all the expected results.Mark if applicable