Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882]#5295
Merged
Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882]#5295
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5295 +/- ##
==========================================
- Coverage 86.71% 86.70% -0.01%
==========================================
Files 193 193
Lines 34750 34764 +14
==========================================
+ Hits 30133 30142 +9
- Misses 4617 4622 +5 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Dec 3, 2024
oshadmi
reviewed
Dec 3, 2024
oshadmi
reviewed
Dec 3, 2024
oshadmi
approved these changes
Dec 3, 2024
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4)
Contributor
|
Successfully created backport PR for |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5295-to-2.6 origin/2.6
cd .worktree/backport-5295-to-2.6
git switch --create backport-5295-to-2.6
git cherry-pick -x a1f6ef42bcb7a6b97c8b5bf433fe2c747db80823 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
* add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4)
Contributor
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Dec 3, 2024
* add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5295) * add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
) Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5295) * add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5295) * add a crashing test * fix bug * review fixes (cherry picked from commit a1f6ef4) Co-authored-by: GuyAv46 <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Validate we managed to create a rune string from the input string and return an error if not.
Which issues this PR fixes
Mark if applicable