Skip to content

[8.0] Remove assertion in optimizer#5293

Merged
GuyAv46 merged 1 commit into8.0from
backport-5273-to-8.0
Dec 2, 2024
Merged

[8.0] Remove assertion in optimizer#5293
GuyAv46 merged 1 commit into8.0from
backport-5273-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

Description

Backport of #5273 to 8.0.

* remove assertion

* reimplement fix

(cherry picked from commit 7fc7645)
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (1a6d894) to head (918fcbe).
Report is 1 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/optimizer_reader.c 53.33% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #5293   +/-   ##
=======================================
  Coverage   86.65%   86.66%           
=======================================
  Files         192      192           
  Lines       34463    34468    +5     
=======================================
+ Hits        29865    29870    +5     
  Misses       4598     4598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 enabled auto-merge December 2, 2024 17:24
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into 8.0 with commit 5b406e1 Dec 2, 2024
@GuyAv46 GuyAv46 deleted the backport-5273-to-8.0 branch December 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant