Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5277 +/- ##
=======================================
Coverage 86.70% 86.71%
=======================================
Files 193 193
Lines 34752 34753 +1
=======================================
+ Hits 30133 30135 +2
+ Misses 4619 4618 -1 ☔ View full report in Codecov by Sentry. |
kei-nan
reviewed
Dec 1, 2024
kei-nan
reviewed
Dec 1, 2024
kei-nan
approved these changes
Dec 1, 2024
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
* add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
* add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
* add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
* add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
Fix Tag OnReopen Callback - [MOD-8011] (#5277) * add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
Fix Tag OnReopen Callback - [MOD-8011] (#5277) * add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
* Fix Tag OnReopen Callback - [MOD-8011] (#5277) * add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e) * fix test for 2.6 --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2024
Fix Tag OnReopen Callback - [MOD-8011] (#5277) * add a test * fix test * fix test * make test crash and not just use-after-free "safely" * fix crash * minor improvement to the test * revert comment fix * improve comment on test (cherry picked from commit 893808e) Co-authored-by: GuyAv46 <[email protected]>
oshadmi
reviewed
Dec 2, 2024
|
|
||
| @skip(cluster=True) | ||
| def testTagIndex_OnReopen(env:Env): # issue MOD-8011 | ||
| n_docs_per_tag_block = 1000 |
Collaborator
There was a problem hiding this comment.
Related to INDEX_BLOCK_SIZE_DOCID_ONLY ? (for Tag)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fixing a bug when we abort from the
TagReader_OnReopencallback prematurely, causing an invalid read later when reading from an iterator that was not reopened properly.Mark if applicable