Skip to content

[8.0] MOD-8054 MOD-8171: Validate index prefixes (#5239)#5271

Merged
raz-mon merged 2 commits into8.0from
razmon-cp_8.0_prefix_validation
Nov 28, 2024
Merged

[8.0] MOD-8054 MOD-8171: Validate index prefixes (#5239)#5271
raz-mon merged 2 commits into8.0from
razmon-cp_8.0_prefix_validation

Conversation

@raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented Nov 27, 2024

CP #5239 and #5272 to 8.0

* wip

* Add index prefix validation for FT.SEARCH

* Some fixes

* Add validation for FT.AGGREGATE

* Fix ref releasing

* Fix test

* Fix tests

* Fix tests

* Remove unused context

* Address review 2

* Address review 3

* Address review 4

* Use VarArgs

* Remove flakiness from cluster initialization
@raz-mon raz-mon requested review from GuyAv46 and oshadmi November 27, 2024 22:08
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 12 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (b40951c) to head (0b30a4c).
Report is 2 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/module.c 83.33% 8 Missing ⚠️
src/aggregate/aggregate_exec.c 0.00% 1 Missing ⚠️
src/aggregate/aggregate_request.c 95.45% 1 Missing ⚠️
src/concurrent_ctx.c 75.00% 1 Missing ⚠️
src/coord/dist_aggregate.c 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #5271   +/-   ##
=======================================
  Coverage   86.65%   86.66%           
=======================================
  Files         192      192           
  Lines       34420    34463   +43     
=======================================
+ Hits        29827    29867   +40     
- Misses       4593     4596    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raz-mon raz-mon enabled auto-merge November 27, 2024 22:32
@raz-mon raz-mon changed the title [8.0] MOD-8054: Validate index prefixes (#5239) [8.0] MOD-8054 MOD-8171: Validate index prefixes (#5239) Nov 28, 2024
@raz-mon raz-mon added this pull request to the merge queue Nov 28, 2024
Merged via the queue into 8.0 with commit a64a024 Nov 28, 2024
@raz-mon raz-mon deleted the razmon-cp_8.0_prefix_validation branch November 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants