Skip to content

[8.0] Fix MRIterator ownership mechanism - [MOD-8108]#5267

Merged
GuyAv46 merged 2 commits into8.0from
backport-5244-to-8.0
Nov 27, 2024
Merged

[8.0] Fix MRIterator ownership mechanism - [MOD-8108]#5267
GuyAv46 merged 2 commits into8.0from
backport-5244-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Nov 27, 2024

Description

Backport of #5244 and #5268 to 8.0.

* implement release mechanism for MRIterator

* refactor MRChannel

* delete CursorList_Expire

* fix test for async cursor deletion

* minor cleanup

* more cleanup

* remove a log message that is now more likely to be logged

* log about stuck RQ less frequently

* even less noisy

* rename MRChannel_Close

(cherry picked from commit 6f68d69)
@GuyAv46 GuyAv46 enabled auto-merge November 27, 2024 14:35
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (f7a03cb) to head (34dc7fa).
Report is 3 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/coord/rmr/rq.c 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.0    #5267      +/-   ##
==========================================
+ Coverage   86.59%   86.66%   +0.07%     
==========================================
  Files         192      192              
  Lines       34407    34384      -23     
==========================================
+ Hits        29795    29800       +5     
+ Misses       4612     4584      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into 8.0 with commit 2e03cd5 Nov 27, 2024
@GuyAv46 GuyAv46 deleted the backport-5244-to-8.0 branch November 27, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant