Skip to content

[MOD-8152] rename and move new metrics#5253

Merged
meiravgri merged 2 commits intomasterfrom
meiravg_rename_metrics
Nov 25, 2024
Merged

[MOD-8152] rename and move new metrics#5253
meiravgri merged 2 commits intomasterfrom
meiravg_rename_metrics

Conversation

@meiravgri
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (7617563) to head (91ef150).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5253   +/-   ##
=======================================
  Coverage   86.69%   86.70%           
=======================================
  Files         193      193           
  Lines       34710    34709    -1     
=======================================
+ Hits        30093    30095    +2     
+ Misses       4617     4614    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

move marked_deleted_vectors to gc section
rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

rename min_memory_index->smallest_memory_index
rename max_memory_index->largest_memory_index

rename errors section -> warnings_and_errors

rename errors_indexing_failures_max->errors_for_index_with_max_failures
@meiravgri meiravgri requested a review from alonre24 November 25, 2024 16:33
@meiravgri meiravgri enabled auto-merge November 25, 2024 16:45
@meiravgri meiravgri added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 6e468f0 Nov 25, 2024
@meiravgri meiravgri deleted the meiravg_rename_metrics branch November 25, 2024 18:19
redisearch-backport-pull-request bot pushed a commit that referenced this pull request Nov 25, 2024
* rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

* rename vecor:mark_deleted_vectors to marked_deleted_vectors
move marked_deleted_vectors to gc section
rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

rename min_memory_index->smallest_memory_index
rename max_memory_index->largest_memory_index

rename errors section -> warnings_and_errors

rename errors_indexing_failures_max->errors_for_index_with_max_failures

(cherry picked from commit 6e468f0)
@redisearch-backport-pull-request
Copy link
Contributor

Successfully created backport PR for 2.10:

@redisearch-backport-pull-request
Copy link
Contributor

Successfully created backport PR for 8.0:

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Nov 25, 2024
* rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

* rename vecor:mark_deleted_vectors to marked_deleted_vectors
move marked_deleted_vectors to gc section
rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

rename min_memory_index->smallest_memory_index
rename max_memory_index->largest_memory_index

rename errors section -> warnings_and_errors

rename errors_indexing_failures_max->errors_for_index_with_max_failures

(cherry picked from commit 6e468f0)
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
[MOD-8152] rename and move new metrics (#5253)

* rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

* rename vecor:mark_deleted_vectors to marked_deleted_vectors
move marked_deleted_vectors to gc section
rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

rename min_memory_index->smallest_memory_index
rename max_memory_index->largest_memory_index

rename errors section -> warnings_and_errors

rename errors_indexing_failures_max->errors_for_index_with_max_failures

(cherry picked from commit 6e468f0)

Co-authored-by: meiravgri <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
[MOD-8152] rename and move new metrics (#5253)

* rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

* rename vecor:mark_deleted_vectors to marked_deleted_vectors
move marked_deleted_vectors to gc section
rename total_logically_deleted_docs ->total_docs_not_collected_by_gc
move from index section to gc section

rename min_memory_index->smallest_memory_index
rename max_memory_index->largest_memory_index

rename errors section -> warnings_and_errors

rename errors_indexing_failures_max->errors_for_index_with_max_failures

(cherry picked from commit 6e468f0)

Co-authored-by: meiravgri <[email protected]>
Co-authored-by: meiravgri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants