Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5239 +/- ##
==========================================
- Coverage 86.70% 86.69% -0.02%
==========================================
Files 193 193
Lines 34709 34788 +79
==========================================
+ Hits 30095 30158 +63
- Misses 4614 4630 +16 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Nov 25, 2024
GuyAv46
reviewed
Nov 25, 2024
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
Very nice!
A few comments and suggestions
oshadmi
reviewed
Nov 25, 2024
oshadmi
reviewed
Nov 25, 2024
oshadmi
reviewed
Nov 25, 2024
oshadmi
reviewed
Nov 25, 2024
oshadmi
previously approved these changes
Nov 26, 2024
GuyAv46
reviewed
Nov 26, 2024
GuyAv46
previously approved these changes
Nov 27, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5239-to-8.0 origin/8.0
cd .worktree/backport-5239-to-8.0
git switch --create backport-5239-to-8.0
git cherry-pick -x 1aeaaaa86a53a1319223689e0572582869669bf9 |
raz-mon
added a commit
that referenced
this pull request
Nov 27, 2024
* wip * Add index prefix validation for FT.SEARCH * Some fixes * Add validation for FT.AGGREGATE * Fix ref releasing * Fix test * Fix tests * Fix tests * Remove unused context * Address review 2 * Address review 3 * Address review 4 * Use VarArgs * Remove flakiness from cluster initialization
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
* MOD-8054: Validate index prefixes (#5239) * wip * Add index prefix validation for FT.SEARCH * Some fixes * Add validation for FT.AGGREGATE * Fix ref releasing * Fix test * Fix tests * Fix tests * Remove unused context * Address review 2 * Address review 3 * Address review 4 * Use VarArgs * Remove flakiness from cluster initialization * Fix flaky cluster initialization test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the validation of index prefixes for the
FT.AGGREGATE,FT.SEARCH,FT.PROFILEcommands between the coordinator and shards.This fixes a potential in which the shard-index may change to a different index with the same name while a query while already dispatched from the coordinator is awaiting the shard execution. This situation may cause an ACL breach, or just yield irrelevant results.
Mark if applicable