MOD-8129: Fix indexed_percent info stat#5238
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5238 +/- ##
==========================================
- Coverage 86.59% 86.59% -0.01%
==========================================
Files 193 193
Lines 34753 34752 -1
==========================================
- Hits 30093 30092 -1
Misses 4660 4660 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
kei-nan
approved these changes
Nov 21, 2024
oshadmi
approved these changes
Nov 21, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5238-to-2.8 origin/2.8
cd .worktree/backport-5238-to-2.8
git switch --create backport-5238-to-2.8
git cherry-pick -x 4ad00e898ef2c29ea37e89e60527d3418a86aa79 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5238-to-2.6 origin/2.6
cd .worktree/backport-5238-to-2.6
git switch --create backport-5238-to-2.6
git cherry-pick -x 4ad00e898ef2c29ea37e89e60527d3418a86aa79 |
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
Fix indexed_percent info stat (cherry picked from commit 4ad00e8)
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
Fix indexed_percent info stat (cherry picked from commit 4ad00e8)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
MOD-8129: Fix indexed_percent info stat (#5238) Fix indexed_percent info stat (cherry picked from commit 4ad00e8) Co-authored-by: Raz Monsonego <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
MOD-8129: Fix indexed_percent info stat (#5238) Fix indexed_percent info stat (cherry picked from commit 4ad00e8) Co-authored-by: Raz Monsonego <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
indexed_percentinfo stat was looking at a potentially not up to date value of the total number of keys in the DB. Since theFT.INFOcall is done by the main-thread we can collect this stat on-the-fly such that it is maximally updated.Also note: The name of the stat is a bit confusing, as this is done in the background. We should consider changing the name to
background_indexing_progress.Mark if applicable