Merged
Conversation
kei-nan
reviewed
Nov 18, 2024
kei-nan
reviewed
Nov 18, 2024
kei-nan
reviewed
Nov 18, 2024
kei-nan
reviewed
Nov 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5224 +/- ##
==========================================
- Coverage 86.59% 86.58% -0.01%
==========================================
Files 193 193
Lines 34769 34753 -16
==========================================
- Hits 30109 30092 -17
- Misses 4660 4661 +1 ☔ View full report in Codecov by Sentry. |
kei-nan
approved these changes
Nov 18, 2024
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix trimming tree logic * make them const (cherry picked from commit f5d68e0)
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5224-to-2.6 origin/2.6
cd .worktree/backport-5224-to-2.6
git switch --create backport-5224-to-2.6
git cherry-pick -x f5d68e00dff70ae81be13737e333a5f2b0979e10 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix trimming tree logic * make them const (cherry picked from commit f5d68e0)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix trimming tree logic * make them const (cherry picked from commit f5d68e0)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Cleanup for the trimming tree logic (#5224) * fix trimming tree logic * make them const (cherry picked from commit f5d68e0) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Cleanup for the trimming tree logic (#5224) * fix trimming tree logic * make them const (cherry picked from commit f5d68e0) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Cleanup for the trimming tree logic (#5224) * fix trimming tree logic * make them const (cherry picked from commit f5d68e0) Co-authored-by: GuyAv46 <[email protected]>
kei-nan
pushed a commit
that referenced
this pull request
Nov 20, 2024
* fix trimming tree logic * make them const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Code cleanup and reduce code duplication
Mark if applicable