[8.0] Add global marked deleted to stats [MOD-6053]#5209
Merged
Conversation
* Add global marked deleted to stats * Fix leak * CR - moving updates to where index spec is held, using int64 for safety * Addressing CR - adding unit test, protecting the update * move for readability * improve test (cherry picked from commit b4d2109)
2 tasks
alonre24
approved these changes
Nov 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5209 +/- ##
==========================================
+ Coverage 86.50% 86.54% +0.03%
==========================================
Files 192 192
Lines 34469 34480 +11
==========================================
+ Hits 29817 29839 +22
+ Misses 4652 4641 -11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5183 to
8.0.