[8.0] Fix Numeric Tree Balance - [MOD-8081, MOD-8082]#5198
Merged
Conversation
* add a failing test * fix maxDepth calculation (balance logic) * fix parent range depth logic * improve test and remove a print * fix test * comment fixes * tidy up * simplified test and address CR * code cleanup and address CR (cherry picked from commit 5884687)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5198 +/- ##
==========================================
- Coverage 86.49% 86.48% -0.01%
==========================================
Files 191 191
Lines 34401 34398 -3
==========================================
- Hits 29754 29750 -4
- Misses 4647 4648 +1 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5185 to
8.0.