[8.0] MOD-7872: Add Types To Hide User Input#5197
Merged
Conversation
* MOD-7872: initial commit * * modify hidden types * * compilation fixes * * get recent updates * * update hidden * Apply suggestions from code review Apply suggestions Co-authored-by: nafraf <[email protected]> * * add tests * * fix hidden test * move obfuscated types to their own header * * add coverage * update length on clone * * remove obfuscated types * * add more testing for more coverage * * add testHiddenDropFromKeySpace for more coverage * implemented missing mock functions to support the new test * * remove obfuscate redundant function * * set correct reply type * * add missing code to get the cpp tests to pass * * free ctx in test * * Code Review - Round #1 --------- Co-authored-by: nafraf <[email protected]> (cherry picked from commit d63f42a)
2 tasks
kei-nan
approved these changes
Nov 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5197 +/- ##
==========================================
+ Coverage 86.42% 86.44% +0.01%
==========================================
Files 191 192 +1
Lines 34503 34573 +70
==========================================
+ Hits 29819 29885 +66
- Misses 4684 4688 +4 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5123 to
8.0.