Performance improvement in indexBulkFields - [MOD-8093]#5186
Merged
Conversation
GuyAv46
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5186 +/- ##
==========================================
+ Coverage 86.43% 86.50% +0.07%
==========================================
Files 192 192
Lines 34784 34686 -98
==========================================
- Hits 30066 30006 -60
+ Misses 4718 4680 -38 ☔ View full report in Codecov by Sentry. |
alonre24
previously approved these changes
Nov 10, 2024
alonre24
approved these changes
Nov 10, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5186-to-2.8 origin/2.8
cd .worktree/backport-5186-to-2.8
git switch --create backport-5186-to-2.8
git cherry-pick -x dfd463fe089bf2f0ef1bc495f206a6925df72ff7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5186-to-2.6 origin/2.6
cd .worktree/backport-5186-to-2.6
git switch --create backport-5186-to-2.6
git cherry-pick -x dfd463fe089bf2f0ef1bc495f206a6925df72ff7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5186-to-2.10 origin/2.10
cd .worktree/backport-5186-to-2.10
git switch --create backport-5186-to-2.10
git cherry-pick -x dfd463fe089bf2f0ef1bc495f206a6925df72ff7 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5186-to-8.0 origin/8.0
cd .worktree/backport-5186-to-8.0
git switch --create backport-5186-to-8.0
git cherry-pick -x dfd463fe089bf2f0ef1bc495f206a6925df72ff7 |
GuyAv46
added a commit
that referenced
this pull request
Nov 10, 2024
* initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f)
GuyAv46
added a commit
that referenced
this pull request
Nov 10, 2024
* initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f)
GuyAv46
added a commit
that referenced
this pull request
Nov 10, 2024
* initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f)
GuyAv46
added a commit
that referenced
this pull request
Nov 10, 2024
* initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f)
This was referenced Nov 10, 2024
oshadmi
reviewed
Nov 11, 2024
Comment on lines
-68
to
-71
| RedisModule_ModuleTypeSetValue(*idxKey, GeometryIndexType, idx); | ||
| return idx; | ||
| } | ||
| if (RedisModule_ModuleTypeGetType(*idxKey) == GeometryIndexType) { |
Collaborator
There was a problem hiding this comment.
@GuyAv46 We can also remove the global GeometryIndexType?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Performance improvement in indexBulkFields - [MOD-8093] (#5186) * initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f) * fixes for 2.6
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Performance improvement in indexBulkFields - [MOD-8093] (#5186) * initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f) * fixes for 2.8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Performance improvement in indexBulkFields - [MOD-8093] (#5186) * initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f) * remove const
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Performance improvement in indexBulkFields - [MOD-8093] (#5186) * initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f) * fix inverted index * remove const
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Performance improvement in indexBulkFields - [MOD-8093] (#5186) * initial cleanup * cleanup tag * cleanup geoshape * cleanup numeric * more cleanup * clean bulk data object * missed code cleanup * improve vecsim delete doc flow * another vecsim improvement (cherry picked from commit dfd463f) * fix inverted index * remove const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
We are removing a redundant caching mechanism in
indexBulkFieldsthat is no longer in use and takes a long time to initialize.The caching mechanism helped with field keys and inverted index caching. The first is no longer relevant, and the second only helps when we use bulk indexing (which we don’t do anymore).
The redundant caching mechanism requires a large memory initialization, which takes a large percentage of the indexing time for no reason.
Note:
This is a performance fix, the bug does not affect the correctness of any search
Future work:
Removing the need for "formatted keys", stop using the spec's dictionary for fields, and store the relevant data in the field spec instead (today we usually extract the field data by first obtaining the field spec by its name, then getting the formatted redis string from it, and lastly performing a dictionary lookup by the formatted key name)
Mark if applicable