Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5184 +/- ##
==========================================
+ Coverage 86.43% 86.50% +0.06%
==========================================
Files 192 192
Lines 34784 34682 -102
==========================================
- Hits 30066 30001 -65
+ Misses 4718 4681 -37 ☔ View full report in Codecov by Sentry. |
oshadmi
reviewed
Nov 10, 2024
Collaborator
|
@raz-mon Where is this change? (BTW it could be considered a breaking change)
|
Collaborator
Author
|
@oshadmi Comment updated, I removed this from this PR. |
GuyAv46
previously approved these changes
Nov 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
GuyAv46
approved these changes
Nov 11, 2024
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
…lidation for FT.SUG* commands (#5196) MOD-8080, MOD-8055: Fix crash on error handling, Add OSS ACL validation for FT.SUG* commands (#5184) * WIP add test * wip * Fix error-handling crash, add OSS support for ACL validation for the FT.SUG* commands * Revert command registration change (for now..) * Fix test * Remove redirection for FT.SUG* in OSS * Fix tests (cherry picked from commit e7eb9d0) Co-authored-by: Raz Monsonego <[email protected]>
This was referenced Oct 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR does the following:
RedisModule_Call()API function causing a NULL response that we did not take into account.FT.SUG*commands so that Redis performs the ACL key validations properly.FT.SUG*commands.Mark if applicable