Add global marked deleted to stats [MOD-6053]#5183
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5183 +/- ##
==========================================
+ Coverage 86.55% 86.59% +0.03%
==========================================
Files 193 193
Lines 34756 34768 +12
==========================================
+ Hits 30083 30106 +23
+ Misses 4673 4662 -11 ☔ View full report in Codecov by Sentry. |
GuyAv46
reviewed
Nov 11, 2024
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
Nice
A few comments
Note that you can hold the GIL in most if not all of the places you used the new counter API. Consider ensuring that and remove the need for atomic counting and reading
meiravgri
reviewed
Nov 12, 2024
Collaborator
meiravgri
left a comment
meiravgri
left a comment
There was a problem hiding this comment.
nice and clean (tartei)
|
|
||
| static void onTerminateCb(void *privdata) { | ||
| ForkGC *gc = privdata; | ||
| IndexsGlobalStats_UpdateLogicallyDeleted(-gc->deletedDocsFromLastRun); |
Collaborator
There was a problem hiding this comment.
is there a scenario where the gc is manually stopped and this callback will not be called?
Collaborator
Author
There was a problem hiding this comment.
Shouldn't be. If so, and the spec is dropped, then no one frees the GC and we get a leak
GuyAv46
previously approved these changes
Nov 12, 2024
meiravgri
approved these changes
Nov 13, 2024
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Add global marked deleted to stats * Fix leak * CR - moving updates to where index spec is held, using int64 for safety * Addressing CR - adding unit test, protecting the update * move for readability * improve test (cherry picked from commit b4d2109)
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Add global marked deleted to stats * Fix leak * CR - moving updates to where index spec is held, using int64 for safety * Addressing CR - adding unit test, protecting the update * move for readability * improve test (cherry picked from commit b4d2109)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Add global marked deleted to stats [MOD-6053] (#5183) * Add global marked deleted to stats * Fix leak * CR - moving updates to where index spec is held, using int64 for safety * Addressing CR - adding unit test, protecting the update * move for readability * improve test (cherry picked from commit b4d2109) * remove monitorDocumentExpiration that wasn't cp'd * deflake test --------- Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Add global marked deleted to stats [MOD-6053] (#5183) * Add global marked deleted to stats * Fix leak * CR - moving updates to where index spec is held, using int64 for safety * Addressing CR - adding unit test, protecting the update * move for readability * improve test (cherry picked from commit b4d2109) * remove monitorDocumentExpiration that wasn't cp'd * deflake test --------- Co-authored-by: alonre24 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Add the total logically deleted documents (i.e., documents that were deleted and have not yet been handled by the GC) among all indexes to the global shard info report.
Mark if applicable