Skip to content

[8.0] Improve usage of RedisModuleCtx#5182

Merged
GuyAv46 merged 1 commit into8.0from
backport-5178-to-8.0
Nov 7, 2024
Merged

[8.0] Improve usage of RedisModuleCtx#5182
GuyAv46 merged 1 commit into8.0from
backport-5178-to-8.0

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

Description

Backport of #5178 to 8.0.

use a valid RedisModuleCtx when logging, generate detached context with the module name instead of the default "<module>"

(cherry picked from commit a93aa64)
@GuyAv46 GuyAv46 enabled auto-merge November 7, 2024 09:42
@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (14e0f26) to head (fce3a6d).
Report is 1 commits behind head on 8.0.

Files with missing lines Patch % Lines
src/rules.c 60.00% 2 Missing ⚠️
src/fork_gc.c 50.00% 1 Missing ⚠️
src/module.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #5182   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         191      191           
  Lines       34499    34496    -3     
=======================================
- Hits        29804    29803    -1     
+ Misses       4695     4693    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into 8.0 with commit 9d647a6 Nov 7, 2024
@GuyAv46 GuyAv46 deleted the backport-5178-to-8.0 branch November 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant