Skip to content

Improve usage of RedisModuleCtx#5178

Merged
GuyAv46 merged 1 commit intomasterfrom
guyav-improve_logging
Nov 7, 2024
Merged

Improve usage of RedisModuleCtx#5178
GuyAv46 merged 1 commit intomasterfrom
guyav-improve_logging

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Nov 6, 2024

Describe the changes in the pull request

  1. Use a valid RedisModuleCtx when logging
  2. Generate a detached context with the module name instead of the default <module>

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

…th the module name instead of the default "<module>"
@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (85a5415) to head (4331e58).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/rules.c 60.00% 2 Missing ⚠️
src/fork_gc.c 50.00% 1 Missing ⚠️
src/module.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
+ Coverage   86.36%   86.38%   +0.01%     
==========================================
  Files         190      191       +1     
  Lines       34701    34761      +60     
==========================================
+ Hits        29971    30028      +57     
- Misses       4730     4733       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
Copy link
Collaborator

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@GuyAv46 GuyAv46 removed this pull request from the merge queue due to a manual request Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
@GuyAv46 GuyAv46 removed this pull request from the merge queue due to a manual request Nov 7, 2024
@GuyAv46 GuyAv46 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit a93aa64 Nov 7, 2024
@GuyAv46 GuyAv46 deleted the guyav-improve_logging branch November 7, 2024 09:39
@redisearch-backport-pull-request
Copy link
Contributor

Successfully created backport PR for 2.10:

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Nov 7, 2024
use a valid RedisModuleCtx when logging, generate detached context with the module name instead of the default "<module>"

(cherry picked from commit a93aa64)
redisearch-backport-pull-request bot pushed a commit that referenced this pull request Nov 7, 2024
use a valid RedisModuleCtx when logging, generate detached context with the module name instead of the default "<module>"

(cherry picked from commit a93aa64)
@redisearch-backport-pull-request
Copy link
Contributor

Successfully created backport PR for 8.0:

github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
Improve usage of RedisModuleCtx (#5178)

use a valid RedisModuleCtx when logging, generate detached context with the module name instead of the default "<module>"

(cherry picked from commit a93aa64)

Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
Improve usage of RedisModuleCtx (#5178)

use a valid RedisModuleCtx when logging, generate detached context with the module name instead of the default "<module>"

(cherry picked from commit a93aa64)

Co-authored-by: GuyAv46 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants