[2.6] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config#5168
Merged
[2.6] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config#5168
Conversation
…obal Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #5168 +/- ##
==========================================
- Coverage 83.79% 83.79% -0.01%
==========================================
Files 178 178
Lines 31269 31279 +10
==========================================
+ Hits 26201 26209 +8
- Misses 5068 5070 +2 ☔ View full report in Codecov by Sentry. |
raz-mon
reviewed
Nov 5, 2024
raz-mon
reviewed
Nov 5, 2024
raz-mon
reviewed
Nov 5, 2024
raz-mon
approved these changes
Nov 6, 2024
raz-mon
added a commit
that referenced
this pull request
Jan 30, 2025
This reverts commit 2ea41bf. Revert "[2.6] Fix Max Frequency Misscalculation - [MOD-8158] (#5559)" This reverts commit 7e0288d. Revert "[2.6] Fix flakiness in a test - [MOD-8611] (#5546)" This reverts commit 1a43260. Revert "[2.6] MOD-8561: Fix Inverted Index SeekTo Edge Case (#5543)" This reverts commit 1c2be01. Revert "Backport 4243 to 2.6 (#5509)" This reverts commit 5d90c3b. Revert "[2.6] Fix legacy geofilter leak - [MOD-8568] (#5519)" This reverts commit 221f139. Revert "MOD-7570 Backport 5422 to 2.6 (#5473)" This reverts commit a0f9d4b. Revert "[2.6] MOD-7864: Obfuscation API (#5486)" This reverts commit 11864ea. Revert "[2.6] MOD-7634: Fix NOSTEM (#5484)" This reverts commit 54a82e0. Revert "[2.6] [MOD-8462] rename total_active_writes -> total_active_write_threads (#5445)" This reverts commit 3805366. Revert "Backport info metrics including index error mechanism to 2.6 [MOD-8450] (#5413)" This reverts commit eb8993c. Revert "[2.6] Fixes for inverted indexes encoding - [MOD-8248] (#5390)" This reverts commit 382bc94. Revert "[2.6] MOD-8221: backport info fields (for metrics) to 2.6 (#5375)" This reverts commit 24790ec. Revert "[2.6] Improve "Raw doc id" encoding - [MOD-8255] (#5374)" This reverts commit 778bf80. Revert "[2.6] Improve SkipToBlock logic - [MOD-8255] (#5368)" This reverts commit 775508c. Revert "[2.6][MOD-8115] Free spec resources in the main thread (#5324) (#5331)" This reverts commit fc7b1a6. Revert "[2.6] Fix Sorting Vector - [MOD-6783] (#5315)" This reverts commit 990cdcb. Revert "[2.6] Fix a flakiness in testCursorOnCoordinator - [MOD-8016] (#5306)" This reverts commit 666db12. Revert "[2.6] Fix long PREFIX/SUFFIX/INFIX/WILDCARD queries - [MOD-7882] (#5302)" This reverts commit 2e0da82. Revert "[2.6] Fix missing expansions in text queries - [MOD-8142] (#5286)" This reverts commit a39acfe. Revert "[2.6] MOD-8188: Fix OnReopen Comments (#5289)" This reverts commit 4a08a98. Revert "[2.6] Fix Tag OnReopen Callback - [MOD-8011] (#5281)" This reverts commit ee4d515. Revert "[2.6] Fix MRIterator ownership mechanism - [MOD-8108] (#5270)" This reverts commit 601002a. Revert "[2.6] MOD-8129: Fix indexed_percent info stat (#5250)" This reverts commit 4dc1713. Revert "[2.6] Fix Numeric Tree Balance - [MOD-8081, MOD-8082] (#5201)" This reverts commit b331af9. Revert "[2.6] Performance improvement in indexBulkFields - [MOD-8093] (#5193)" This reverts commit 54c9ded. Revert "[2.6] MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5168)" This reverts commit b86fcda. Revert "[2.6] Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5107)" This reverts commit 4c09577. Revert "[2.6] Fix flaky test (#5085)" This reverts commit 8cf0465.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #5137 to 2.6.