Send SCORER to the shards with FT.AGGREGATE on cluster mode - [MOD-8060]#5162
Merged
Send SCORER to the shards with FT.AGGREGATE on cluster mode - [MOD-8060]#5162
SCORER to the shards with FT.AGGREGATE on cluster mode - [MOD-8060]#5162Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5162 +/- ##
==========================================
- Coverage 86.37% 86.36% -0.01%
==========================================
Files 190 190
Lines 34668 34672 +4
==========================================
+ Hits 29943 29944 +1
- Misses 4725 4728 +3 ☔ View full report in Codecov by Sentry. |
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…e - [MOD-8060] (#5163) Send `SCORER` to the shards with `FT.AGGREGATE` on cluster mode - [MOD-8060] (#5162) * adding a failing test * fixing the bug (cherry picked from commit ae92aa4) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
… - [MOD-8060] (#5164) Send `SCORER` to the shards with `FT.AGGREGATE` on cluster mode - [MOD-8060] (#5162) * adding a failing test * fixing the bug (cherry picked from commit ae92aa4) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Propagating the
SCORERattribute to the shards onFT.AGGREGATEcluster modeMark if applicable