Add Active Indices Metrics - [MOD-7952]#5160
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5160 +/- ##
==========================================
+ Coverage 86.37% 86.43% +0.06%
==========================================
Files 190 192 +2
Lines 34701 34787 +86
==========================================
+ Hits 29972 30069 +97
+ Misses 4729 4718 -11 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Nov 6, 2024
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
* old IndexStats cleanup * count read and write operations * added count of active indices to the info command * add total active writes and total active queries gauges * rename variables (cherry picked from commit 41b53c5)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
* old IndexStats cleanup * count read and write operations * added count of active indices to the info command * add total active writes and total active queries gauges * rename variables (cherry picked from commit 41b53c5)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Add Active Indices Metrics - [MOD-7952] (#5160) * old IndexStats cleanup * count read and write operations * added count of active indices to the info command * add total active writes and total active queries gauges * rename variables (cherry picked from commit 41b53c5) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Add Active Indices Metrics - [MOD-7952] (#5160) * old IndexStats cleanup * count read and write operations * added count of active indices to the info command * add total active writes and total active queries gauges * rename variables (cherry picked from commit 41b53c5) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Adding atomic counters to IndexSpec for active index usage, and utilizing them for new global gauges under the
indexsection of the info command:number_of_active_indexesnumber_of_active_indexes_running_queriesnumber_of_active_indexes_indexingtotal_active_writesIn addition, we added a new field under the
querysection:total_active_queriesMark if applicable