[8.0] [MOD-8034] expose indexing failures to INFO modules#5155
Merged
Conversation
* move fieldsStats from RSGlobalConfig to RSGlobalStats move dialects stats to global_stats * Introduce a global counter for indexing failures for each field type. The counter is update at runtime, once the error occured. It reflects the total number of indexing errors in all living indices. The counter should be decreased whenever an index is dropped. introduce FieldSpec_AddError that adds an error to a specific field. it also updates the global field error counter. We expose the global counter value in INFO modules, along with each field type stats. the name of the fields count for each type was changed from "Field_type_name" to "Total" * fix test * skip test_redis_info_errors in cluster wait for bg index after FT.ALTER to avoid flakyness * revert change in INFO MODULES field count name * fix test format * fix test flakyness remove IndexingErrorsStats and put the fields in TotalSpecsInfo (cherry picked from commit 9ef9bd9)
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5155 +/- ##
==========================================
+ Coverage 86.30% 86.31% +0.01%
==========================================
Files 189 189
Lines 34354 34380 +26
==========================================
+ Hits 29649 29675 +26
Misses 4705 4705 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5139 to
8.0.