Skip to content

Add metrics of min and max memory consumption of indexes - [MOD-7584]#5143

Merged
GuyAv46 merged 2 commits intomasterfrom
guyav-metrics_memory
Oct 31, 2024
Merged

Add metrics of min and max memory consumption of indexes - [MOD-7584]#5143
GuyAv46 merged 2 commits intomasterfrom
guyav-metrics_memory

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Oct 31, 2024

Describe the changes in the pull request

Add new metrics for minimal and maximal index memory consumption.
We add both byte count and MB values for both the min and max metrics.

New metrics:

  1. search_min_memory_index
  2. search_min_memory_index_human
  3. search_max_memory_index
  4. search_max_memory_index_human

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@GuyAv46 GuyAv46 requested a review from meiravgri October 31, 2024 12:27
meiravgri
meiravgri approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@meiravgri meiravgri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spectacular

@codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (8cffbb6) to head (5b030a1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5143   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files         190      190           
  Lines       34614    34623    +9     
=======================================
+ Hits        29884    29892    +8     
- Misses       4730     4731    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit b0d56ad Oct 31, 2024
@GuyAv46 GuyAv46 deleted the guyav-metrics_memory branch October 31, 2024 15:00
@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Oct 31, 2024

Successfully created backport PR for 8.0:

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Oct 31, 2024
@GuyAv46 @github-actions
Add metrics of min and max memory consumption of indexes - [MOD-7584] (…
a659fb5 
…#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Oct 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@redisearch-backport-pull-request @GuyAv46
[8.0] Add metrics of min and max memory consumption of indexes - [MOD…
7c55ba5 
…-7584] (#5144)

Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)

Co-authored-by: GuyAv46 <[email protected]>
@GuyAv46
Copy link
Collaborator Author

GuyAv46 commented Nov 3, 2024

/backport

@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Nov 3, 2024

Successfully created backport PR for 2.10:

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Nov 3, 2024
@GuyAv46 @github-actions
Add metrics of min and max memory consumption of indexes - [MOD-7584] (…
e93cf32 
…#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Nov 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2024
@redisearch-backport-pull-request @GuyAv46
[2.10] Add metrics of min and max memory consumption of indexes - [MO…
094318f 
…D-7584] (#5146)

Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)

Co-authored-by: GuyAv46 <[email protected]>
oshadmi pushed a commit that referenced this pull request Dec 17, 2024
@redisearch-backport-pull-request @oshadmi
Add metrics of min and max memory consumption of indexes - [MOD-7584] (…
31d2739 
…#5143)

(cherry picked from commit 094318f)
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2024
@oshadmi @raz-mon @redisearch-backport-pull-request
[2.8] MOD-8221: backport info fields (for metrics) to 2.8 (#5358)
b7eaa56 
* MOD-6846: Enhance INFO response (#4561)

(cherry picked from commit 73e717f)

(cherry picked from commit 71a4af2)

(cherry picked from commit 6a2c6fa)

* MOD-6846: Replace average cycle time with total time in Redis `INFO` (#4590)

* Replace average cycle time with total time

* Change INFO field name to correspond to FT.INFO field name

(cherry picked from commit 71a4af2)

* Fix failure with redis 5.0.5 output

* Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

(cherry picked from commit 094318f)

* Code review fix

* Try fix dnf install conflicting requests

---------

Co-authored-by: Raz Monsonego <[email protected]>
Co-authored-by: redisearch-backport-pull-request[bot] <182669528+redisearch-backport-pull-request[bot]@users.noreply.github.com>
alonre24 pushed a commit that referenced this pull request Dec 27, 2024
@redisearch-backport-pull-request @GuyAv46 @alonre24
[2.10] Add metrics of min and max memory consumption of indexes - [MO…
7dec0bb 
…D-7584] (#5146)

Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)

Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit 094318f)
github-merge-queue bot pushed a commit that referenced this pull request Jan 1, 2025
@alonre24 @redisearch-backport-pull-request
@GuyAv46 @meiravgri
Backport metrics info 2.8 [MOD-8388] (#5407)
f428033 
* CP Count Queries - [MOD-6492]

* [2.10] Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5146)

Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

* implement min and max memory usage metrics

* added to info module test

(cherry picked from commit b0d56ad)

Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit 094318f)

* [2.10] Add a counter of total query execution time - [MOD-7961] (#5153)

* Add a counter of total query execution time - [MOD-7961] (#5145)

* complete CP of "Count Queries" (#5072) content

* always count query execution time (on non-internal commands)

* add test

* give more time

* review fixes

(cherry picked from commit 97f34e2)

* add missing if

(cherry picked from commit d45365d)

* CP [MOD-8034] expose indexing failures to INFO modules

* [2.10] Add VecSim related metrics - [MOD-7967] (#5169)

Add VecSim related metrics - [MOD-7967] (#5151)

* added vector info

* added a test

* drain work queue before checking memory

* move vector metrics info field statistics section

* fix test

* fix test

* tidy up

* added a flat index to the test

(cherry picked from commit 388f81e)

Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit 242f314)

* CP Add Active Indices Metrics - [MOD-7952]

* CP Add global marked deleted to stats [MOD-6053]

* CP Fork gc code cleanup (PR #4263) to enable GC mechanism that will allow the test of marked deleted info to pass

* CP [MOD-8152] rename and move new metrics

* CP [MOD-8035] Add field index error for JSON field indexing failures

* CP [MOD-8039] Reorganize stats files

* [2.10] Improve counting active writes - [MOD-8151] (#5362)

Improve counting active writes - [MOD-8151] (#5354)

* improve counting active writes

* add a test

(cherry picked from commit 2b5182d)

Co-authored-by: GuyAv46 <[email protected]>
(cherry picked from commit a3d447d)

* Update mem usage computation to align to 2.10

* revert bad additions (CR)

* revert bad additions (CR) 2

* Better memory check in info vecsim (since mac failed)

* Fix syntax error

---------

Co-authored-by: redisearch-backport-pull-request[bot] <182669528+redisearch-backport-pull-request[bot]@users.noreply.github.com>
Co-authored-by: GuyAv46 <[email protected]>
Co-authored-by: meiravgri <[email protected]>
@meiravgri meiravgri mentioned this pull request Apr 7, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiravgri meiravgri meiravgri approved these changes

Assignees

No one assigned

Labels

backport 2.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuyAv46 @meiravgri