Skip to content

[8.0] Remove an unnecessary assertion - [MOD-8008]#5141

Merged
GuyAv46 merged 1 commit into8.0from
backport-5138-to-8.0
Oct 31, 2024
Merged

[8.0] Remove an unnecessary assertion - [MOD-8008]#5141
GuyAv46 merged 1 commit into8.0from
backport-5138-to-8.0

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Oct 31, 2024

Description

Backport of #5138 to 8.0.

* remove unneeded assertion

* added a test

(cherry picked from commit 8cffbb6)
@GuyAv46 GuyAv46 added the bug label Oct 31, 2024
@GuyAv46 GuyAv46 requested a review from alonre24 October 31, 2024 09:44
@GuyAv46 GuyAv46 enabled auto-merge October 31, 2024 09:48
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (b56f3b0) to head (4f5100f).
Report is 1 commits behind head on 8.0.

Additional details and impacted files
@@           Coverage Diff           @@
##              8.0    #5141   +/-   ##
=======================================
  Coverage   86.27%   86.28%           
=======================================
  Files         189      189           
  Lines       34316    34326   +10     
=======================================
+ Hits        29607    29617   +10     
  Misses       4709     4709           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into 8.0 with commit 7dfe024 Oct 31, 2024
@GuyAv46 GuyAv46 deleted the backport-5138-to-8.0 branch October 31, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants