Remove an unnecessary assertion - [MOD-8008]#5138
Merged
Conversation
GuyAv46
commented
Oct 30, 2024
| /* start the event loop side thread */ | ||
| static void sideThread(void *arg) { | ||
| REDISMODULE_NOT_USED(arg); | ||
| RedisModule_Assert(__atomic_load_n(&pendingTopo, __ATOMIC_ACQUIRE)); |
Collaborator
Author
There was a problem hiding this comment.
The redundant assertion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5138 +/- ##
=======================================
Coverage 86.33% 86.34%
=======================================
Files 190 190
Lines 34604 34614 +10
=======================================
+ Hits 29875 29887 +12
+ Misses 4729 4727 -2 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Oct 31, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5138-to-2.10 origin/2.10
cd .worktree/backport-5138-to-2.10
git switch --create backport-5138-to-2.10
git cherry-pick -x 8cffbb6171a1c1665f8a07c217e7dd6688188536 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5138-to-8.0 origin/8.0
cd .worktree/backport-5138-to-8.0
git switch --create backport-5138-to-8.0
git cherry-pick -x 8cffbb6171a1c1665f8a07c217e7dd6688188536 |
GuyAv46
added a commit
that referenced
this pull request
Oct 31, 2024
* remove unneeded assertion * added a test (cherry picked from commit 8cffbb6)
GuyAv46
added a commit
that referenced
this pull request
Oct 31, 2024
* remove unneeded assertion * added a test (cherry picked from commit 8cffbb6)
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
We removed an unnecessary assertion in the UV thread initialization that verifies the shard has topology information waiting before the first distributed command is sent.
The assertion is unnecessary because we have a mechanism that sets aside jobs until we can send them to all the relevant shards.
Note that still, no command will be sent until the topology is set.
Mark if applicable